Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colab notebook not working #286

Closed
vaclavhanzl opened this issue Mar 6, 2023 · 9 comments
Closed

Colab notebook not working #286

vaclavhanzl opened this issue Mar 6, 2023 · 9 comments

Comments

@vaclavhanzl
Copy link
Contributor

vaclavhanzl commented Mar 6, 2023

Colab notebook pointed to from the main page is not working for multiple reasons, throwing quite confusing error messages.
I tried to fix it by PR #285. You can test the fixed notebook here. Testers welcome!

@vaclavhanzl
Copy link
Contributor Author

vaclavhanzl commented Apr 10, 2023

Colab notebook was fixed by merging my #285 but at the same day broken again by also merging #287 :)
Now Colab fails on missing modelcif dependency, This should be easy to fix.

@vaclavhanzl
Copy link
Contributor Author

vaclavhanzl commented Apr 25, 2023

I fixed it again in #308.

If you want to try my fix before it is merged, it is a bit tricky this time but you can. Open the notebook here and edit the Install OpenFold cell (change GIT_REPO and add branch checkout):

#GIT_REPO='https://github.com/aqlaboratory/openfold'
GIT_REPO='https://github.com/vaclavhanzl/openfold'
...
    %shell git clone "{GIT_REPO}" openfold 2>&1 1> /dev/null
    %shell cd openfold && git checkout colab-add-dep-fix-python-version

@burunduk57
Copy link

Colab notebook was fixed by merging my #285 but at the same day broken again by also merging #287 :) Now Colab fails on missing modelcif dependency, This should be easy to fix.

I get missing modelcif problem

@vaclavhanzl
Copy link
Contributor Author

vaclavhanzl commented May 9, 2023

I get missing modelcif problem

@burunduk57 and you would get more problems down the road (changed parameters of functions and a very cryptic failure due to Python version discrepancy). I proposed a fix but until it gets merged, you can try this:

Open the notebook here and edit the Install OpenFold cell (change GIT_REPO and add branch checkout):

#GIT_REPO='https://github.com/aqlaboratory/openfold'
GIT_REPO='https://github.com/vaclavhanzl/openfold'
...
    %shell git clone "{GIT_REPO}" openfold 2>&1 1> /dev/null
    %shell cd openfold && git checkout colab-add-dep-fix-python-version

Edit: This is no longer enough to make it work but see my next comment for an easier way which works.

@vaclavhanzl
Copy link
Contributor Author

@burunduk57 to make it easier for you (and for others), I merged all my fixes in my fork of the OpenFold repo and just added one more fix (openmm version). Please try my fixed version of the Colab notebook. It works for me now.

@burunduk57
Copy link

@burunduk57 to make it easier for you (and for others), I merged all my fixes in my fork of the OpenFold repo and just added one more fix (openmm version). Please try my fixed version of the Colab notebook. It works for me now.

It works for me, many thanks!

@vaclavhanzl
Copy link
Contributor Author

This notebook is really cat-n-mouse game :) What worked 5 days ago does not work now. My fix was finally just merged to main now, but now the notebook fails at:

%shell conda install -y -q -c conda-forge pdbfixer

I'll look into it once more, maybe there are more things to be automated (my auto-following of the python version already saved us one breakage).

@vaclavhanzl
Copy link
Contributor Author

vaclavhanzl commented May 18, 2023

I fixed it in #320.
Until it gets merged, you can again use fixed Colab in my repo fork.

@vaclavhanzl
Copy link
Contributor Author

Merged (thanks @gahdritz), tested, works! Closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants