Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support installing Go benchmark analysis tools #823

Closed
suzuki-shunsuke opened this issue Jun 1, 2022 · 3 comments · Fixed by #826
Closed

Support installing Go benchmark analysis tools #823

suzuki-shunsuke opened this issue Jun 1, 2022 · 3 comments · Fixed by #826
Labels
enhancement New feature or request
Projects
main
Milestone
v1.10.0

Comments

@suzuki-shunsuke
Copy link
Member

suzuki-shunsuke commented Jun 1, 2022 •
edited

https://cs.opensource.google/go/x/perf
The problem is that these tools aren't managed in GitHub.

Related
@suzuki-shunsuke suzuki-shunsuke added the enhancement New feature or request label Jun 1, 2022
@suzuki-shunsuke
Copy link
Member Author

We can specify the install path the environment variable GOBIN.

$ GOBIN=$PWD/bin go install golang.org/x/perf/cmd/benchstat@latest

@suzuki-shunsuke suzuki-shunsuke added this to To do in main via automation Jun 1, 2022
@suzuki-shunsuke suzuki-shunsuke moved this from To do to In progress in main Jun 1, 2022
@suzuki-shunsuke
Copy link
Member Author

suzuki-shunsuke commented Jun 1, 2022 •
edited

e.g.

packages:
  - name: golang.org/x/perf/cmd/benchstat
    type: go_install
    path: golang.org/x/perf/cmd/benchstat
    description: Benchstat computes and compares statistics about benchmarks
AQUA_ROOT_DIR/
  pkgs/
    go_install/
      golang.org/x/perf/cmd/benchstat/
        <version>/
          benchstat

$AQUA_ROOT_DIR/pkgs/go_install/<Go package path>/<version>/<executable file name>

@suzuki-shunsuke
Copy link
Member Author

Merge with go package.

$AQUA_ROOT_DIR/pkgs/go/<Go package path>/<version>/bin/<executable file name>

@suzuki-shunsuke suzuki-shunsuke mentioned this issue Jun 1, 2022
Merged
@suzuki-shunsuke suzuki-shunsuke added this to the v1.10.0 milestone Jun 1, 2022
main automation moved this from In progress to Done Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
No open projects
main
Done
Milestone
v1.10.0
Development

Successfully merging a pull request may close this issue.

feat: add a package type go_install aquaproj/aqua
1 participant
@suzuki-shunsuke