Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add option to avoid showing progress bar #976

Closed
4513ECHO opened this issue Jul 1, 2022 · 7 comments · Fixed by #979
Closed

[Feature Request] Add option to avoid showing progress bar #976

4513ECHO opened this issue Jul 1, 2022 · 7 comments · Fixed by #979
Labels
enhancement New feature or request
Milestone

Comments

@4513ECHO
Copy link
Contributor

4513ECHO commented Jul 1, 2022

Feature Overview

Add --no-progress-bar ( --no-progress ) option to avoid showing progress bar in package installation.

Why is the feature needed?

Please explain the problem you want to solve.

Progress bar is useful in usual using on terminal, but it is sometimes obstructed a bit such as on test log of GitHub Action. Also, progress bar uses some escape sequences, and it sometimes broken. I don't always want progress bar.

Does the feature include Breaking Changes?

No.

Example Code

command and configuration

`install` subcommand option
$ aqua install --no-progress-bar
$ aqua install --no-progress
global option
$ aqua --no-progress-bar install
$ aqua --no-progress install

Reference

@suzuki-shunsuke
Copy link
Member

Thank you for your proposal.
I think the environment variable is better because Lazy Install also shows the progress bar.

e.g.

export AQUA_NO_PROGRESS_BAR=true

@suzuki-shunsuke suzuki-shunsuke added the enhancement New feature or request label Jul 1, 2022
@suzuki-shunsuke
Copy link
Member

progress bar uses some escape sequences, and it sometimes broken.

Do you know how to reproduce? Does this occur in other than CI?

@suzuki-shunsuke suzuki-shunsuke pinned this issue Jul 1, 2022
@suzuki-shunsuke
Copy link
Member

schollz/progressbar#97

@suzuki-shunsuke
Copy link
Member

#979

@suzuki-shunsuke
Copy link
Member

I consider to disable the progress bar by default, because this feature isn't so important but it may cause trouble depending on the environment.

@suzuki-shunsuke suzuki-shunsuke unpinned this issue Jul 2, 2022
@suzuki-shunsuke suzuki-shunsuke added this to the v1.16.1 milestone Jul 2, 2022
@suzuki-shunsuke
Copy link
Member

@suzuki-shunsuke
Copy link
Member

https://github.com/aquaproj/aqua/releases/tag/v1.17.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants