Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChannelGuildCategory missing some major fields #67

Closed
yutotakano opened this issue Apr 30, 2021 · 2 comments
Closed

ChannelGuildCategory missing some major fields #67

yutotakano opened this issue Apr 30, 2021 · 2 comments

Comments

@yutotakano
Copy link
Member

The fields available in the current ChannelGuildCategory ADT are quite limited currently, as seen here: https://github.com/aquarial/discord-haskell/blob/ffe46538c508f498b7cd98367c2aec16ede7e8e7/src/Discord/Internal/Types/Channel.hs#L117-L120

This raises some inconsistencies, as R.ModifyChannel can modify positions and permission overwrites of both channels and categories, while it is only possible to retrieve them for normal channels through R.GetChannel.

Discord's blog post on categories highlights that categories can have permission overwrites and positions. More concretely, the rightmost column in the table in the relevant docs show that all types of channels have permission_overwrites and position. Although this seems misleading since DM channels for one don't have those, I think we can be sure that category channels would have those fields.

Could these be implemented?

@aquarial
Copy link
Collaborator

Yeah this is a good idea. I can work on it

@aquarial
Copy link
Collaborator

Updated 1.8.6 with this change

Thanks for providing detailed report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants