Skip to content
This repository has been archived by the owner on Feb 25, 2023. It is now read-only.

gravel/glass: user management #578

Merged
merged 1 commit into from Jul 9, 2021
Merged

gravel/glass: user management #578

merged 1 commit into from Jul 9, 2021

Conversation

votdev
Copy link
Member

@votdev votdev commented Jun 18, 2021 •
edited

The default credentials set up during deployment are: admin/aquarium

Peek 2021-06-25 17-27

Peek 2021-06-25 17-40

Fixes: #421
Fixes: #23
Fixes: #26

Signed-off-by: Volker Theile vtheile@suse.com

Checklist

  • References issues, create if required
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
Show available Jenkins commands
  • jenkins test tumbleweed
  • jenkins run tumbleweed
  • jenkins test leap
  • jenkins run leap

@votdev votdev added feature New feature glass Related to the Aquarium Frontend gravel Related to the Aquarium Backend labels Jun 18, 2021
@votdev votdev added this to the Milestone 5 milestone Jun 18, 2021
@votdev votdev requested a review from jecluis June 18, 2021 10:17
@votdev votdev added this to In progress in Project Aquarium via automation Jun 18, 2021
jecluis
jecluis suggested changes Jun 18, 2021
View reviewed changes
Copy link
Member

@jecluis jecluis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few things of note, and we need tests for this.

src/aquarium.py Outdated Show resolved Hide resolved
src/gravel/api/auth.py Outdated Show resolved Hide resolved
src/gravel/api/auth.py Outdated Show resolved Hide resolved
src/gravel/api/user.py Outdated Show resolved Hide resolved
src/gravel/api/user.py Outdated Show resolved Hide resolved
src/gravel/api/user.py Outdated Show resolved Hide resolved
src/gravel/controllers/user.py Outdated Show resolved Hide resolved
src/gravel/controllers/user.py Outdated Show resolved Hide resolved
src/gravel/controllers/user.py Outdated Show resolved Hide resolved
src/gravel/api/user.py Outdated Show resolved Hide resolved
Project Aquarium automation moved this from In progress to Review in progress Jun 18, 2021
@votdev votdev force-pushed the auth branch 19 times, most recently from e346419 to e658931 Compare June 25, 2021 09:54
@votdev votdev force-pushed the auth branch 2 times, most recently from 28ef96b to e1e0ebb Compare June 25, 2021 15:21
@votdev votdev requested a review from Devp00l June 25, 2021 15:28
@s0nea
Copy link
Member

s0nea commented Jul 1, 2021

I just setup a testing environment for the PR. While doing this two questions came into my mind:

* Would it be sensible to print the default username/password by e.g. the `run_aquarium.sh` script?

I think this makes little sense given the user won't be able to see the console.

It was just an idea because I setup the environment and then I had to look up the credentials in the code.

@jecluis
Copy link
Member

jecluis commented Jul 1, 2021

OK, i can add a username and password page to the Create wizard. The SSH pubkey should be done in a separate issue/PR.

I think both can/should be a different PR. We might not want to hold this one right now. Also, this one still needs tests to be merged, even if basic ones.

@votdev votdev force-pushed the auth branch 7 times, most recently from e73dafb to bfffebf Compare July 2, 2021 09:24
@votdev
Copy link
Member Author

votdev commented Jul 2, 2021

jenkins test tumbleweed

@s0nea
Copy link
Member

s0nea commented Jul 2, 2021

Somehow I can't re-enable a deactivated user:

aqua.mp4

Any ideas?

@votdev
Copy link
Member Author

votdev commented Jul 2, 2021

Somehow I can't re-enable a deactivated user:
aqua.mp4

Any ideas?

Fixed

@s0nea
Copy link
Member

s0nea commented Jul 5, 2021

jenkins test leap

@votdev
gravel/glass: user management
13355f0 
The default credentials set up during deployment are: admin/aquarium

Fixes: aquarist-labs#421
Fixes: aquarist-labs#23
Fixes: aquarist-labs#26

Signed-off-by: Volker Theile <vtheile@suse.com>
@votdev
Copy link
Member Author

votdev commented Jul 6, 2021

jenkins test tumbleweed

@votdev votdev requested a review from jecluis July 6, 2021 08:28
@votdev votdev mentioned this pull request Jul 6, 2021
Merged
Project Aquarium automation moved this from Review in progress to Reviewer approved Jul 7, 2021
s0nea
s0nea approved these changes Jul 7, 2021
View reviewed changes
Copy link
Member

@s0nea s0nea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The glass part LGTM!

I suggest to wait for @jecluis's final review before merging the PR.

@jecluis jecluis merged commit e96e559 into aquarist-labs:main Jul 9, 2021
Project Aquarium automation moved this from Reviewer approved to Done Jul 9, 2021
@votdev votdev deleted the auth branch July 9, 2021 12:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@p-se p-se p-se left review comments

@jecluis jecluis jecluis approved these changes

@s0nea s0nea s0nea approved these changes

@Devp00l Devp00l Awaiting requested review from Devp00l

Assignees
No one assigned
Labels
aqr: Must Have Absolutely necessary to have for Aquarium as a Project feature New feature glass Related to the Aquarium Frontend gravel Related to the Aquarium Backend prio: medium Medium Priority Issue
Projects
Project Aquarium
Done
Milestone
Milestone 5
Development

Successfully merging this pull request may close these issues.

glass: user management gravel: user management glass: create a login page
5 participants
@votdev @codecov-commenter @p-se @s0nea @jecluis