Skip to content
This repository has been archived by the owner on Feb 25, 2023. It is now read-only.

tools/aqua: add multiple deployment types #642

Merged
merged 9 commits into from Oct 11, 2021
Merged

tools/aqua: add multiple deployment types #642

merged 9 commits into from Oct 11, 2021

Conversation

kshtsk
Copy link
Contributor

@kshtsk kshtsk commented Sep 3, 2021

Signed-off-by: Kyr Shatskyy kyrylo.shatskyy@suse.com

Checklist

  • References issues, create if required
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
Show available Jenkins commands
  • jenkins test tumbleweed
  • jenkins run tumbleweed
  • jenkins test leap
  • jenkins run leap

@jecluis jecluis marked this pull request as draft September 6, 2021 05:46
@jecluis jecluis added the tooling Related with tools supporting development or deployment label Sep 6, 2021
@jecluis jecluis added this to In progress in Project Aquarium via automation Sep 6, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2021 •
edited

Codecov Report

Merging #642 (ea1e8fb) into main (eb4410c) will not change coverage.
The diff coverage is n/a.

❗ Current head ea1e8fb differs from pull request most recent head 3663337. Consider uploading reports for the commit 3663337 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main     #642   +/-   ##
=======================================
  Coverage   69.00%   69.00%           
=======================================
  Files          34       34           
  Lines        3142     3142           
=======================================
  Hits         2168     2168           
  Misses        974      974

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb4410c...3663337. Read the comment docs.

@github-actions github-actions bot added the CI label Sep 8, 2021
@kshtsk kshtsk force-pushed the wip-deployments branch 5 times, most recently from 16c3799 to c3199b8 Compare September 8, 2021 21:03
@kshtsk
Copy link
Contributor Author

kshtsk commented Sep 9, 2021

jenkins test tumbleweed

@kshtsk kshtsk force-pushed the wip-deployments branch 2 times, most recently from 8cd783c to e55d4d2 Compare September 9, 2021 11:38
@kshtsk
Copy link
Contributor Author

kshtsk commented Sep 9, 2021

jenkins run ubuntu

@kshtsk
Copy link
Contributor Author

kshtsk commented Sep 9, 2021

jenkins run ubuntu

@kshtsk kshtsk changed the title [DNM][WIP] tools/aqua: multiple deployment types [DNM][WIP] tools/aqua: add multiple deployment types Sep 9, 2021
@kshtsk
Copy link
Contributor Author

kshtsk commented Sep 9, 2021

jenkins test ubuntu

@kshtsk
Copy link
Contributor Author

kshtsk commented Sep 9, 2021

jenkins test leap

@kshtsk
Copy link
Contributor Author

kshtsk commented Sep 9, 2021

jenkins test tumbleweed

@kshtsk
Copy link
Contributor Author

kshtsk commented Sep 11, 2021

jenkins test ubuntu

1 similar comment
@kshtsk
Copy link
Contributor Author

kshtsk commented Sep 12, 2021

jenkins test ubuntu

@kshtsk kshtsk mentioned this pull request Sep 14, 2021
Merged
@kshtsk
Copy link
Contributor Author

kshtsk commented Sep 21, 2021 •
edited

jenkins run leap

@kshtsk
Copy link
Contributor Author

kshtsk commented Sep 21, 2021

jenkins run tumbleweed

@kshtsk
Copy link
Contributor Author

kshtsk commented Sep 21, 2021

jenkins run leap

@kshtsk
Copy link
Contributor Author

kshtsk commented Sep 22, 2021

jenkins run tumbleweed

@kshtsk
Copy link
Contributor Author

kshtsk commented Sep 22, 2021

jenkins run leap

@kshtsk kshtsk force-pushed the wip-deployments branch 2 times, most recently from bc46b42 to ec67b24 Compare October 1, 2021 21:53
@kshtsk
Copy link
Contributor Author

kshtsk commented Oct 4, 2021

jenkins run tumbleweed

@kshtsk
Copy link
Contributor Author

kshtsk commented Oct 4, 2021

jenkins run ubuntu

1 similar comment
@kshtsk
Copy link
Contributor Author

kshtsk commented Oct 4, 2021

jenkins run ubuntu

@kshtsk kshtsk force-pushed the wip-deployments branch 2 times, most recently from 6af6203 to be10ce4 Compare October 5, 2021 14:42
jecluis
jecluis suggested changes Oct 6, 2021
View reviewed changes
Copy link
Member

@jecluis jecluis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally looks good, but there's quite a few formatting issues I'd like to see fixed before being merged.

tools/libaqua/cli.py Show resolved Hide resolved
tools/libaqua/cli.py Outdated Show resolved Hide resolved
tools/libaqua/images.py Outdated Show resolved Hide resolved
tools/libaqua/images.py Outdated Show resolved Hide resolved
tools/libaqua/images.py Show resolved Hide resolved
tools/libaqua/libvirt/__init__.py Outdated Show resolved Hide resolved
tools/libaqua/libvirt/__init__.py Show resolved Hide resolved
tools/libaqua/libvirt/__init__.py Outdated Show resolved Hide resolved
tools/libaqua/tests/test_deployment.py Show resolved Hide resolved
tools/libaqua/tests/test_deployment.py Show resolved Hide resolved
Kyr Shatskyy and others added 9 commits October 8, 2021 15:05
@kshtsk
tools/aqua: multiple deployment types
f40515c 
introduce libvirt deployment and split the vagrant deployment
from the base deployment class

Signed-off-by: Kyr Shatskyy <kyrylo.shatskyy@suse.com>
@kshtsk
aqua: move vagrant file generation to vagrant module
9cd2b80 
Signed-off-by: Kyr Shatskyy <kyrylo.shatskyy@suse.com>
@kshtsk
aqua: change deployment dir
d7e3750 
Instead of REPOROOT/tests/vagrant/deployments directory
use REPOROOT/.aqua/deployment directory for storing
deployment config files.

Signed-off-by: Kyr Shatskyy <kyrylo.shatskyy@suse.com>
@kshtsk
github: add aqua unit tests workflow
f686d62 
We don't want no more regressions.

Signed-off-by: Kyr Shatskyy <kyrylo.shatskyy@suse.com>
@kshtsk
wasser: run pytest for aqua
332b808 
Signed-off-by: Kyr Shatskyy <kyrylo.shatskyy@suse.com>
@kshtsk
wasser: source tools/venv for ubuntu
718ee58 
Signed-off-by: Kyr Shatskyy <kyrylo.shatskyy@gmail.com>
@kshtsk
tools/setup-dev: add libvirt-python
dada7a5 
Signed-off-by: Kyr Shatskyy <kyrylo.shatskyy@suse.com>
@kshtsk
tools/setup-dev: use --system-site-packages for tools/venv
b9de0d8 
We do not want to rebuild from source package like libvirt-python.

Signed-off-by: Kyr Shatskyy <kyrylo.shatskyy@gmail.com>
@kshtsk
aqua: add --disk-size parameter
0fbdbfe 
Signed-off-by: Kyr Shatskyy <kyrylo.shatskyy@gmail.com>
@kshtsk kshtsk requested a review from jecluis October 8, 2021 13:34
@kshtsk
Copy link
Contributor Author

kshtsk commented Oct 8, 2021

@jecluis I think I addressed your comments.

jecluis
jecluis approved these changes Oct 11, 2021
View reviewed changes
Copy link
Member

@jecluis jecluis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not test it but I trust you did and it works fine (i.e., doesn't break anything).

Project Aquarium automation moved this from Review in progress to Reviewer approved Oct 11, 2021
@kshtsk kshtsk merged commit 4bb873e into aquarist-labs:main Oct 11, 2021
Project Aquarium automation moved this from Reviewer approved to Done Oct 11, 2021
@kshtsk kshtsk deleted the wip-deployments branch October 11, 2021 12:09
@kshtsk
Copy link
Contributor Author

kshtsk commented Oct 11, 2021

Did not test it but I trust you did and it works fine (i.e., doesn't break anything).

thank you :-) but that sounded like you do not trust, just you have no time to test it and in your prayers you hope it will not break :-D

@jecluis
Copy link
Member

jecluis commented Oct 11, 2021

Naaa. I meant I'm trusting you as a good developer that it will not break what already exists, even if the full functionality of what you are trying to achieve is not there yet (i.e., it might not fully work). Hence why I'm not testing it myself. :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jecluis jecluis jecluis approved these changes

Assignees
No one assigned
Labels
CI tooling Related with tools supporting development or deployment
Projects
Project Aquarium
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kshtsk @codecov-commenter @jecluis