Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

livenessProbe and readinessProbe for Console #73

Closed
amalucelli opened this issue Jan 28, 2020 · 3 comments
Closed

livenessProbe and readinessProbe for Console #73

amalucelli opened this issue Jan 28, 2020 · 3 comments

Comments

@amalucelli
Copy link
Contributor

Hi, I see this block code where I can input some probe for liveness and readiness, but I can't find any default value that I can use to determine if the console is healty or ready.

Is possible to know if the console implements any of those? I tried the knowledge base but couldn't find anything useful.

{{- with .Values.web.livenessProbe }}
livenessProbe:
{{ toYaml . | indent 10 }}
{{- end }}
{{- with .Values.web.readinessProbe }}
readinessProbe:
{{ toYaml . | indent 10 }}
{{- end }}

@agilgur5
Copy link
Contributor

Yea, I would think that all liveness and readiness probes should be configured out-of-the-box, as they are responsible for determining application health/readiness. That's not quite something an end user should have to know about as the app needs to expose those itself.

The block of code referenced is actually visible in all deployments, not just Console.

@rshmiel
Copy link
Contributor

rshmiel commented Dec 24, 2020

@amalucelli thanks for reporting. Fixed see above PR.

@rshmiel rshmiel closed this as completed Dec 24, 2020
@agilgur5
Copy link
Contributor

The block of code referenced is actually visible in all deployments, not just Console.

So the above PR only added probes to one deployment, the Console. Other charts here, such as the Enforcers, still don't seem to have any probes... Should a separate issue be opened to address those...?

The PR also implemented identical liveness and readiness probes against the / endpoint -- do the Console and other Aqua tools not have their own dedicated healthcheck endpoints that perform appropriate status checks? (e.g. /healthz that checks if DB is responsive etc)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants