Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log callback is passing escaped output #313

Closed
geyslan opened this issue Mar 30, 2023 · 3 comments · Fixed by #312
Closed

log callback is passing escaped output #313

geyslan opened this issue Mar 30, 2023 · 3 comments · Fixed by #312
Assignees
Labels
bug Something isn't working

Comments

@geyslan
Copy link
Member

geyslan commented Mar 30, 2023

As reported by @yanivagman, libbpf output is being passed via callback as escaped:

v(id=2733) R8_w=ctx(id=0,off=0,imm=0) R9=inv(id=2735) R10=fp0 fp-8=mmmmmmmm fp-16=mmmmmmmm fp-24=mmmmmmmm fp-32=mmmmmmmm fp-40=mmmmmmmm fp-48=mmmmmmmm fp-56=mmmmmmmm fp-64=mmmmmmmm fp-72=inv7628147 fp-80=inv7737014201346191213 fp-88=map_value fp-96=ctx fp-104=map_value fp-112=map_value fp-120=map_value fp-128=map_value fp-136=map_value fp-144=map_value fp-152=mmmmmmmm fp-160=invP500\n; u32 size = sizeof(event_context_t) + p->event->buf_off;\n7693: (07) r5 += 128\n; asm volatile(\"if %[size] < %[max_size] goto +1;\\n\"\n7694: (a5) if r5 < 0x7d80 goto pc+1\nThe sequence of 8193 jumps is too complex.\nprocessed 87116 insns (limit 1000000) max_states_per_insn 2 total_states 2835 peak_states 2835 mark_read 1000\n-- END PROG LOAD LOG --

instead of:

v(id=2733) R8_w=ctx(id=0,off=0,imm=0) R9=inv(id=2735) R10=fp0 fp-8=mmmmmmmm fp-16=mmmmmmmm fp-24=mmmmmmmm fp-32=mmmmmmmm fp-40=mmmmmmmm fp-48=mmmmmmmm fp-56=mmmmmmmm fp-64=mmmmmmmm fp-72=inv7628147 fp-80=inv7737014201346191213 fp-88=map_value fp-96=ctx fp-104=map_value fp-112=map_value fp-120=map_value fp-128=map_value fp-136=map_value fp-144=map_value fp-152=mmmmmmmm fp-160=invP500
; u32 size = sizeof(event_context_t) + p->event->buf_off;
7693: (07) r5 += 128
; asm volatile(\"if %[size] < %[max_size] goto +1;\n"
7694: (a5) if r5 < 0x7d80 goto pc+1
The sequence of 8193 jumps is too complex.
processed 87116 insns (limit 1000000) max_states_per_insn 2 total_states 2835 peak_states 2835 mark_read 1000
-- END PROG LOAD LOG --
@geyslan geyslan added the bug Something isn't working label Mar 30, 2023
@geyslan geyslan self-assigned this Mar 30, 2023
@geyslan
Copy link
Member Author

geyslan commented Mar 31, 2023

See conclusion: #312 (comment)

@rafaeldtinoco
Copy link
Contributor

See conclusion: #312 (comment)

Should we close this then ?

@geyslan
Copy link
Member Author

geyslan commented Apr 3, 2023

Yes. Should close this. The formatting must be a consumer responsibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants