-
Notifications
You must be signed in to change notification settings - Fork 197
/
configauditreport.go
510 lines (453 loc) · 17.5 KB
/
configauditreport.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
package controller
import (
. "github.com/aquasecurity/starboard/pkg/operator/predicate"
"context"
"fmt"
"github.com/aquasecurity/starboard/pkg/apis/aquasecurity/v1alpha1"
"github.com/aquasecurity/starboard/pkg/configauditreport"
"github.com/aquasecurity/starboard/pkg/kube"
"github.com/aquasecurity/starboard/pkg/operator/etc"
"github.com/aquasecurity/starboard/pkg/starboard"
"github.com/go-logr/logr"
appsv1 "k8s.io/api/apps/v1"
batchv1 "k8s.io/api/batch/v1"
batchv1beta1 "k8s.io/api/batch/v1beta1"
corev1 "k8s.io/api/core/v1"
rbacv1 "k8s.io/api/rbac/v1"
apiextensionsv1 "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1"
"k8s.io/apimachinery/pkg/api/errors"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
ctrl "sigs.k8s.io/controller-runtime"
"sigs.k8s.io/controller-runtime/pkg/builder"
"sigs.k8s.io/controller-runtime/pkg/client"
"sigs.k8s.io/controller-runtime/pkg/controller/controllerutil"
"sigs.k8s.io/controller-runtime/pkg/reconcile"
)
type ConfigAuditReportReconciler struct {
logr.Logger
etc.Config
starboard.ConfigData
client.Client
kube.ObjectResolver
LimitChecker
kube.LogsReader
configauditreport.Plugin
starboard.PluginContext
configauditreport.ReadWriter
}
func (r *ConfigAuditReportReconciler) SetupWithManager(mgr ctrl.Manager) error {
installModePredicate, err := InstallModePredicate(r.Config)
if err != nil {
return err
}
resources := []struct {
kind kube.Kind
forObject client.Object
ownsObject client.Object
}{
{kind: kube.KindPod, forObject: &corev1.Pod{}, ownsObject: &v1alpha1.ConfigAuditReport{}},
{kind: kube.KindReplicaSet, forObject: &appsv1.ReplicaSet{}, ownsObject: &v1alpha1.ConfigAuditReport{}},
{kind: kube.KindReplicationController, forObject: &corev1.ReplicationController{}, ownsObject: &v1alpha1.ConfigAuditReport{}},
{kind: kube.KindStatefulSet, forObject: &appsv1.StatefulSet{}, ownsObject: &v1alpha1.ConfigAuditReport{}},
{kind: kube.KindDaemonSet, forObject: &appsv1.DaemonSet{}, ownsObject: &v1alpha1.ConfigAuditReport{}},
{kind: kube.KindCronJob, forObject: &batchv1beta1.CronJob{}, ownsObject: &v1alpha1.ConfigAuditReport{}},
{kind: kube.KindJob, forObject: &batchv1.Job{}, ownsObject: &v1alpha1.ConfigAuditReport{}},
{kind: kube.KindService, forObject: &corev1.Service{}, ownsObject: &v1alpha1.ConfigAuditReport{}},
{kind: kube.KindConfigMap, forObject: &corev1.ConfigMap{}, ownsObject: &v1alpha1.ConfigAuditReport{}},
{kind: kube.KindRole, forObject: &rbacv1.Role{}, ownsObject: &v1alpha1.ConfigAuditReport{}},
{kind: kube.KindRoleBinding, forObject: &rbacv1.RoleBinding{}, ownsObject: &v1alpha1.ConfigAuditReport{}},
}
clusterResources := []struct {
kind kube.Kind
forObject client.Object
ownsObject client.Object
}{
{kind: kube.KindClusterRole, forObject: &rbacv1.ClusterRole{}, ownsObject: &v1alpha1.ClusterConfigAuditReport{}},
{kind: kube.KindClusterRoleBindings, forObject: &rbacv1.ClusterRoleBinding{}, ownsObject: &v1alpha1.ClusterConfigAuditReport{}},
{kind: kube.KindCustomResourceDefinition, forObject: &apiextensionsv1.CustomResourceDefinition{}, ownsObject: &v1alpha1.ClusterConfigAuditReport{}},
}
for _, resource := range resources {
if !r.supportsKind(resource.kind) {
r.Logger.Info("Skipping unsupported kind", "pluginName", r.PluginContext.GetName(), "kind", resource.kind)
continue
}
err = ctrl.NewControllerManagedBy(mgr).
For(resource.forObject, builder.WithPredicates(
Not(ManagedByStarboardOperator),
Not(IsLeaderElectionResource),
Not(IsBeingTerminated),
installModePredicate,
)).
Owns(resource.ownsObject).
Complete(r.reconcileResource(resource.kind))
if err != nil {
return fmt.Errorf("constructing controller for %s: %w", resource.kind, err)
}
}
for _, resource := range clusterResources {
if !r.supportsKind(resource.kind) {
r.Logger.Info("Skipping unsupported kind", "pluginName", r.PluginContext.GetName(), "kind", resource.kind)
continue
}
err = ctrl.NewControllerManagedBy(mgr).
For(resource.forObject, builder.WithPredicates(
Not(ManagedByStarboardOperator),
Not(IsBeingTerminated),
)).
Owns(resource.ownsObject).
Complete(r.reconcileResource(resource.kind))
if err != nil {
return fmt.Errorf("constructing controller for %s: %w", resource.kind, err)
}
}
return ctrl.NewControllerManagedBy(mgr).
For(&batchv1.Job{}, builder.WithPredicates(
InNamespace(r.Config.Namespace),
ManagedByStarboardOperator,
IsConfigAuditReportScan,
JobHasAnyCondition,
)).
Complete(r.reconcileJobs())
}
func (r *ConfigAuditReportReconciler) supportsKind(kind kube.Kind) bool {
for _, k := range r.Plugin.SupportedKinds() {
if k == kind {
return true
}
}
return false
}
func (r *ConfigAuditReportReconciler) reconcileResource(resourceKind kube.Kind) reconcile.Func {
return func(ctx context.Context, req ctrl.Request) (ctrl.Result, error) {
log := r.Logger.WithValues("kind", resourceKind, "name", req.NamespacedName)
resourceRef := kube.ObjectRefFromKindAndObjectKey(resourceKind, req.NamespacedName)
log.V(1).Info("Getting resource from cache")
resource, err := r.ObjectFromObjectRef(ctx, resourceRef)
if err != nil {
if errors.IsNotFound(err) {
log.V(1).Info("Ignoring cached resource that must have been deleted")
return ctrl.Result{}, nil
}
return ctrl.Result{}, fmt.Errorf("getting %s from cache: %w", resourceKind, err)
}
// Skip processing if a resource is a Pod controlled by a built-in K8s workload.
if resourceKind == kube.KindPod {
controller := metav1.GetControllerOf(resource)
if kube.IsBuiltInWorkload(controller) {
log.V(1).Info("Ignoring managed pod",
"controllerKind", controller.Kind,
"controllerName", controller.Name)
return ctrl.Result{}, nil
}
labels := resource.GetLabels()
// Ignore scanning of pod which is created for deploymentConfig
if value, ok := labels[kube.DeployerPodForDeploymentLabel]; ok {
log.V(1).Info("Ignoring system pod created for deployment config",
"deploymentConfigName", value)
return ctrl.Result{}, nil
}
}
if r.Config.ConfigAuditScannerScanOnlyCurrentRevisions && resourceKind == kube.KindReplicaSet {
controller := metav1.GetControllerOf(resource)
activeReplicaSet, err := r.IsActiveReplicaSet(ctx, resource, controller)
if err != nil {
return ctrl.Result{}, fmt.Errorf("failed checking current revision: %w", err)
}
if !activeReplicaSet {
log.V(1).Info("Ignoring inactive ReplicaSet", "controllerKind", controller.Kind, "controllerName", controller.Name)
return ctrl.Result{}, nil
}
}
if r.Config.ConfigAuditScannerScanOnlyCurrentRevisions && resourceKind == kube.KindReplicationController {
controller := metav1.GetControllerOf(resource)
activeReplicaSet, err := r.IsActiveReplicationController(ctx, resource, controller)
if err != nil {
return ctrl.Result{}, fmt.Errorf("failed checking current revision: %w", err)
}
if !activeReplicaSet {
log.V(1).Info("Ignoring inactive ReplicationController", "controllerKind", controller.Kind, "controllerName", controller.Name)
return ctrl.Result{}, nil
}
}
// Skip processing if a resource is a Job controlled by CronJob.
if resourceKind == kube.KindJob {
controller := metav1.GetControllerOf(resource)
if controller != nil && controller.Kind == string(kube.KindCronJob) {
log.V(1).Info("Ignoring managed job", "controllerKind", controller.Kind, "controllerName", controller.Name)
return ctrl.Result{}, nil
}
}
// Skip processing if plugin is not applicable to this object
applicable, reason, err := r.Plugin.IsApplicable(r.PluginContext, resource)
if err != nil {
return ctrl.Result{}, fmt.Errorf("checking whether plugin is applicable: %w", err)
}
if !applicable {
log.V(1).Info("Pushing back reconcile key",
"reason", reason,
"pluginName", r.PluginContext.GetName(),
"retryAfter", r.ScanJobRetryAfter)
// TODO Introduce more generic param to retry processing a given key.
return ctrl.Result{RequeueAfter: r.Config.ScanJobRetryAfter}, nil
}
resourceSpecHash, err := kube.ComputeSpecHash(resource)
if err != nil {
return ctrl.Result{}, fmt.Errorf("computing spec hash: %w", err)
}
pluginConfigHash, err := r.Plugin.ConfigHash(r.PluginContext, kube.Kind(resource.GetObjectKind().GroupVersionKind().Kind))
if err != nil {
return ctrl.Result{}, fmt.Errorf("computing plugin config hash: %w", err)
}
log = log.WithValues("resourceSpecHash", resourceSpecHash, "pluginConfigHash", pluginConfigHash)
log.V(1).Info("Checking whether configuration audit report exists")
hasReport, err := r.hasReport(ctx, resourceRef, resourceSpecHash, pluginConfigHash)
if err != nil {
return ctrl.Result{}, err
}
if hasReport {
log.V(1).Info("Configuration audit report exists")
return ctrl.Result{}, nil
}
log.V(1).Info("Checking whether configuration audit has been scheduled")
_, job, err := r.hasActiveScanJob(ctx, resource, resourceSpecHash)
if err != nil {
return ctrl.Result{}, err
}
if job != nil {
log.V(1).Info("Configuration audit has been scheduled",
"job", fmt.Sprintf("%s/%s", job.Namespace, job.Name))
return ctrl.Result{}, nil
}
limitExceeded, scanJobsCount, err := r.LimitChecker.Check(ctx)
if err != nil {
return ctrl.Result{}, err
}
log.V(1).Info("Checking scan jobs limit", "count", scanJobsCount, "limit", r.ConcurrentScanJobsLimit)
if limitExceeded {
log.V(1).Info("Pushing back reconcile key",
"reason", "scan jobs limit exceeded",
"scanJobsCount", scanJobsCount,
"retryAfter", r.ScanJobRetryAfter)
return ctrl.Result{RequeueAfter: r.Config.ScanJobRetryAfter}, nil
}
scanJobTolerations, err := r.ConfigData.GetScanJobTolerations()
if err != nil {
return ctrl.Result{}, fmt.Errorf("getting scan job tolerations: %w", err)
}
scanJobAnnotations, err := r.ConfigData.GetScanJobAnnotations()
if err != nil {
return ctrl.Result{}, fmt.Errorf("getting scan job annotations: %w", err)
}
scanJobPodTemplateLabels, err := r.GetScanJobPodTemplateLabels()
if err != nil {
return ctrl.Result{}, fmt.Errorf("getting scan job template labels: %w", err)
}
job, secrets, err := configauditreport.NewScanJobBuilder().
WithPlugin(r.Plugin).
WithPluginContext(r.PluginContext).
WithTimeout(r.Config.ScanJobTimeout).
WithObject(resource).
WithTolerations(scanJobTolerations).
WithAnnotations(scanJobAnnotations).
WithPodTemplateLabels(scanJobPodTemplateLabels).
Get()
if err != nil {
return ctrl.Result{}, fmt.Errorf("constructing scan job: %w", err)
}
for _, secret := range secrets {
err := r.Client.Create(ctx, secret)
if err != nil {
if errors.IsAlreadyExists(err) {
log.V(1).Info("Secret already exists", "secretName", secret.Name)
return ctrl.Result{}, nil
}
return ctrl.Result{}, fmt.Errorf("creating secret: %w", err)
}
}
log.V(1).Info("Scheduling configuration audit", "secrets", len(secrets))
err = r.Client.Create(ctx, job)
if err != nil {
if errors.IsAlreadyExists(err) {
// TODO Delete secrets that were created in the previous step. Alternatively we can delete them on schedule.
log.V(1).Info("Job already exists", "jobName", job.Name)
return ctrl.Result{}, nil
}
return ctrl.Result{}, fmt.Errorf("creating job: %w", err)
}
for _, secret := range secrets {
err := controllerutil.SetOwnerReference(job, secret, r.Client.Scheme())
if err != nil {
return ctrl.Result{}, fmt.Errorf("setting owner reference: %w", err)
}
err = r.Client.Update(ctx, secret)
if err != nil {
return ctrl.Result{}, fmt.Errorf("updating secret: %w", err)
}
}
return ctrl.Result{}, nil
}
}
func (r *ConfigAuditReportReconciler) hasReport(ctx context.Context, owner kube.ObjectRef, podSpecHash string, pluginConfigHash string) (bool, error) {
if kube.IsClusterScopedKind(string(owner.Kind)) {
return r.hasClusterReport(ctx, owner, podSpecHash, pluginConfigHash)
}
// TODO FindByOwner should accept optional label selector to further narrow down search results
report, err := r.ReadWriter.FindReportByOwner(ctx, owner)
if err != nil {
return false, err
}
if report != nil {
return report.Labels[starboard.LabelResourceSpecHash] == podSpecHash &&
report.Labels[starboard.LabelPluginConfigHash] == pluginConfigHash, nil
}
return false, nil
}
func (r *ConfigAuditReportReconciler) hasClusterReport(ctx context.Context, owner kube.ObjectRef, podSpecHash string, pluginConfigHash string) (bool, error) {
report, err := r.ReadWriter.FindClusterReportByOwner(ctx, owner)
if err != nil {
return false, err
}
if report != nil {
return report.Labels[starboard.LabelResourceSpecHash] == podSpecHash &&
report.Labels[starboard.LabelPluginConfigHash] == pluginConfigHash, nil
}
return false, nil
}
func (r *ConfigAuditReportReconciler) hasActiveScanJob(ctx context.Context, obj client.Object, hash string) (bool, *batchv1.Job, error) {
jobName := configauditreport.GetScanJobName(obj)
job := &batchv1.Job{}
err := r.Client.Get(ctx, client.ObjectKey{Namespace: r.Config.Namespace, Name: jobName}, job)
if err != nil {
if errors.IsNotFound(err) {
return false, nil, nil
}
return false, nil, fmt.Errorf("getting pod from cache: %w", err)
}
if job.Labels[starboard.LabelResourceSpecHash] == hash {
return true, job, nil
}
return false, nil, nil
}
func (r *ConfigAuditReportReconciler) reconcileJobs() reconcile.Func {
return func(ctx context.Context, req ctrl.Request) (ctrl.Result, error) {
log := r.Logger.WithValues("job", req.NamespacedName)
job := &batchv1.Job{}
log.V(1).Info("Getting job from cache")
err := r.Client.Get(ctx, req.NamespacedName, job)
if err != nil {
if errors.IsNotFound(err) {
log.V(1).Info("Ignoring cached job that must have been deleted")
return ctrl.Result{}, nil
}
return ctrl.Result{}, fmt.Errorf("getting job from cache: %w", err)
}
if len(job.Status.Conditions) == 0 {
log.V(1).Info("Ignoring job without conditions")
return ctrl.Result{}, nil
}
switch jobCondition := job.Status.Conditions[0].Type; jobCondition {
case batchv1.JobComplete:
err = r.processCompleteScanJob(ctx, job)
case batchv1.JobFailed:
err = r.processFailedScanJob(ctx, job)
default:
err = fmt.Errorf("unrecognized job condition: %v", jobCondition)
}
return ctrl.Result{}, err
}
}
func (r *ConfigAuditReportReconciler) processCompleteScanJob(ctx context.Context, job *batchv1.Job) error {
log := r.Logger.WithValues("job", fmt.Sprintf("%s/%s", job.Namespace, job.Name))
ownerRef, err := kube.ObjectRefFromObjectMeta(job.ObjectMeta)
if err != nil {
return fmt.Errorf("getting owner ref from scan job metadata: %w", err)
}
owner, err := r.ObjectFromObjectRef(ctx, ownerRef)
if err != nil {
if errors.IsNotFound(err) {
log.V(1).Info("Report owner must have been deleted", "owner", owner)
return r.deleteJob(ctx, job)
}
return fmt.Errorf("getting object from object ref: %w", err)
}
resourceSpecHash, ok := job.Labels[starboard.LabelResourceSpecHash]
if !ok {
return fmt.Errorf("expected label %s not set", starboard.LabelResourceSpecHash)
}
pluginConfigHash, ok := job.Labels[starboard.LabelPluginConfigHash]
if !ok {
return fmt.Errorf("expected label %s not set", starboard.LabelPluginConfigHash)
}
hasReport, err := r.hasReport(ctx, ownerRef, resourceSpecHash, pluginConfigHash)
if err != nil {
return err
}
if hasReport {
log.V(1).Info("ConfigAuditReport already exist", "owner", owner)
log.V(1).Info("Deleting complete scan job", "owner", owner)
return r.deleteJob(ctx, job)
}
logsStream, err := r.LogsReader.GetLogsByJobAndContainerName(ctx, job, r.Plugin.GetContainerName())
if err != nil {
if errors.IsNotFound(err) {
log.V(1).Info("Cached job must have been deleted")
return nil
}
if kube.IsPodControlledByJobNotFound(err) {
log.V(1).Info("Pod must have been deleted")
return r.deleteJob(ctx, job)
}
return fmt.Errorf("getting logs: %w", err)
}
reportData, err := r.Plugin.ParseConfigAuditReportData(r.PluginContext, logsStream)
defer func() {
_ = logsStream.Close()
}()
if err != nil {
return err
}
reportBuilder := configauditreport.NewReportBuilder(r.Client.Scheme()).
Controller(owner).
ResourceSpecHash(resourceSpecHash).
PluginConfigHash(pluginConfigHash).
Data(reportData)
err = reportBuilder.Write(ctx, r.ReadWriter)
if err != nil {
return err
}
log.V(1).Info("Deleting complete scan job", "owner", owner)
return r.deleteJob(ctx, job)
}
func (r *ConfigAuditReportReconciler) processFailedScanJob(ctx context.Context, scanJob *batchv1.Job) error {
log := r.Logger.WithValues("job", fmt.Sprintf("%s/%s", scanJob.Namespace, scanJob.Name))
statuses, err := r.LogsReader.GetTerminatedContainersStatusesByJob(ctx, scanJob)
if err != nil {
if errors.IsNotFound(err) {
log.V(1).Info("Cached job must have been deleted")
return nil
}
if kube.IsPodControlledByJobNotFound(err) {
log.V(1).Info("Pod must have been deleted")
return r.deleteJob(ctx, scanJob)
}
return err
}
for container, status := range statuses {
if status.ExitCode == 0 {
continue
}
log.Error(nil, "Scan job container", "container", container, "status.reason", status.Reason, "status.message", status.Message)
}
log.V(1).Info("Deleting failed scan job")
return r.Client.Delete(ctx, scanJob, client.PropagationPolicy(metav1.DeletePropagationBackground))
}
func (r *ConfigAuditReportReconciler) deleteJob(ctx context.Context, job *batchv1.Job) error {
err := r.Client.Delete(ctx, job, client.PropagationPolicy(metav1.DeletePropagationBackground))
if err != nil {
if errors.IsNotFound(err) {
return nil
}
return fmt.Errorf("deleting job: %w", err)
}
return nil
}