Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(input): add path to secret config file #292

Closed
DmitriyLewen opened this issue Dec 26, 2023 · 5 comments · Fixed by #296
Closed

feat(input): add path to secret config file #292

DmitriyLewen opened this issue Dec 26, 2023 · 5 comments · Fixed by #296

Comments

@DmitriyLewen
Copy link
Contributor

Description

Trivy has config file and secret config file, but trivy-action has input (with field) only for path to config file.
Is it possible to add input for path to secret config file?

Related discussions

@simar7
Copy link
Member

simar7 commented Jan 2, 2024

We already have support for config-file as you mentioned. Can the path to the secret config file be specified form it? Like so:

secret:
  # Same as '--secret-config'
  # Default is 'trivy-secret.yaml'
  config: config/trivy/secret.yaml

See https://aquasecurity.github.io/trivy/v0.48/docs/references/configuration/config-file/#secret-options

@DmitriyLewen
Copy link
Contributor Author

I thought about this way, but it is not obvious way for users without Trivy experience.
It might be worth adding information about this method to the README.
wdyt?

@simar7
Copy link
Member

simar7 commented Jan 9, 2024

I thought about this way, but it is not obvious way for users without Trivy experience.

It might be worth adding information about this method to the README.

wdyt?

Yeah sure we can certainly improve the documentation. Would you like to submit a PR? I can take a look.

@DmitriyLewen
Copy link
Contributor Author

Okay, i will create PR and write to you.

@DmitriyLewen
Copy link
Contributor Author

Hello @simar7
I created #296
Can you take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants