Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TFSEC extension seems to fight hashicorp official for comment toggle #24

Open
drewmullen opened this issue Feb 7, 2022 · 3 comments
Open

Comments

@drewmullen
Copy link

Describe the bug

Upon VSCode restart I cannot toggle comments (cmd + /) unless i disable tfsec then reenable it.

Desktop (please complete the following information):

  • OS: [e.g. Windows] macos
  • Tfsec Version [e.g. v0.62.0] 0.58.14
  • tfsec extension 1.74.4

VSCode Version:
Version: 1.63.2
Commit: 899d46d82c4c95423fb7e10e68eba52050e30ba3
Date: 2021-12-15T09:37:28.172Z (1 mo ago)
Electron: 13.5.2
Chromium: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Darwin x64 19.6.0

Additional context

hashicorp/vscode-terraform#692
hashicorp/vscode-terraform#635

@owenrumney
Copy link
Contributor

I understand what you're saying, but I can replicate and I use the official Terraform plugin

any chance you could do a gif showing the issue and post here?

@drewmullen
Copy link
Author

drewmullen commented Feb 7, 2022

Trying to find a way to replicate consistently. One clarification, the comment toggle seems to be specifically terraform.tfvars files. which uses this language mode:
image

@owenrumney
Copy link
Contributor

that's weird because the tfsec extension should only interact with the .tf files. I'll have a fiddle too

@owenrumney owenrumney removed their assignment Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants