New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up demo codespace #1122
Set up demo codespace #1122
Conversation
…m/aqueducthq/aqueduct into ENG-2546-setup-aqueduct-codespace
…G-2546-setup-aqueduct-codespace
…G-2546-setup-aqueduct-codespace
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
@likawind, a couple questions:
|
@vsreekanti yes, we should keep it up to date. I will update release script / checklist once the PR is pushed. For schedules, the thing is we run the entire example notebooks to publish them in the codespace, so the schedule follows whatever in these notebooks. I'm not sure if we should change the notebooks since they serve for other purposes. The easiest thing to do is to add a server flag so that we skip backfilling skipped workflows on start time? |
I'd be okay with removing the schedules from the example notebooks. If people are running those, there's no reason that they would want it to actually update every day. 🙂 |
@vsreekanti updated all schedules, this PR should be good to go |
Describe your changes and why you are making these changes
This PR adds necessary change to deploy a demo codespace that consists of all example notebooks. User can browse these workflows in UI and also play around with the notebooks. We also added a readme to instruct the user to do so.
Caveats:
sentiment
as it requires torch. The resulting img will be 5G and it crashes container build (I believe the dkr pull exceed the size limit).Related issue number (if any)
ENG-2546
Loom demo (if any)
This link should work: https://github.com/codespaces/new?hide_repo_select=true&ref=demo_codespace&repo=496844646
Checklist before requesting a review
python3 scripts/run_linters.py -h
for usage).run_integration_test
: Runs integration testsskip_integration_test
: Skips integration tests (Should be used when changes are ONLY documentation/UI)