Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebase for serenity:0.11.4 and songbird:0.3.0 #197

Merged
merged 14 commits into from
Aug 2, 2022

Conversation

StaticRocket
Copy link
Contributor

@StaticRocket StaticRocket commented May 23, 2022

Well, we should be good to go. There's a lot here. Needs some reviews before I'm comfortable with it.

This just rips out the permission system entirely right now. We should set some safe defaults later.

Resolves #196
Resolves #146

@StaticRocket
Copy link
Contributor Author

Getting closer. Only obvious thing left is some weird behavior when the user isn't in the same voice channel as the bot. May have mangled permissions somewhere... I'll sort it tomorrow.

@afonsojramos
Copy link
Collaborator

Excited to see the changes! Let me know if you need any help! @StaticRocket

@StaticRocket StaticRocket changed the title Prepare for serenity:next and songbird:next Rebase for serenity:0.11.4 and songbird:0.3.0 Jul 29, 2022
@StaticRocket StaticRocket marked this pull request as ready for review July 29, 2022 05:40
@StaticRocket
Copy link
Contributor Author

@afonsojramos a review when you have time would be great!

@joao-conde joao-conde added the 🔧 improvement General improvements to existing features label Jul 29, 2022
@joao-conde
Copy link
Collaborator

@StaticRocket alter the workflows too to bump minimal rust version

@StaticRocket
Copy link
Contributor Author

Huh, I didn't know that information is stored repos now.

@StaticRocket
Copy link
Contributor Author

What is the best way to add cmake to the base image the docker workflow uses?

@afonsojramos
Copy link
Collaborator

What is the best way to add cmake to the base image the docker workflow uses?

I can take a look in a bit if that's the true issue. But if it is just that, it should be easy!

@StaticRocket
Copy link
Contributor Author

I'm an idiot. I looked at the docker file the other day to try and change the rust version and completely ignored the apt commands specifically installing necessary build tools. We should be good now, cmake is here.

@afonsojramos
Copy link
Collaborator

It seems that it was audiopus_sys@v0.2.0 that started having the cmake dependency.

Copy link
Collaborator

@afonsojramos afonsojramos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@joao-conde joao-conde merged commit dedb298 into aquelemiguel:main Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔧 improvement General improvements to existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Command permission update procedure has changed Allow disabling the DJ role
3 participants