-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebase for serenity:0.11.4 and songbird:0.3.0 #197
Conversation
Getting closer. Only obvious thing left is some weird behavior when the user isn't in the same voice channel as the bot. May have mangled permissions somewhere... I'll sort it tomorrow. |
Excited to see the changes! Let me know if you need any help! @StaticRocket |
@afonsojramos a review when you have time would be great! |
@StaticRocket alter the workflows too to bump minimal rust version |
Huh, I didn't know that information is stored repos now. |
What is the best way to add cmake to the base image the docker workflow uses? |
I can take a look in a bit if that's the true issue. But if it is just that, it should be easy! |
I'm an idiot. I looked at the docker file the other day to try and change the rust version and completely ignored the apt commands specifically installing necessary build tools. We should be good now, cmake is here. |
It seems that it was audiopus_sys@v0.2.0 that started having the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Well, we should be good to go. There's a lot here. Needs some reviews before I'm comfortable with it.
This just rips out the permission system entirely right now. We should set some safe defaults later.
Resolves #196
Resolves #146