You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Minor bug in the Makefile I found while building QEMU. The IS_MINGW check in the Makefile fails under MSYS2 MinGW-w64 because cc --version doesn't have mingw in the output anymore:
$ whereis cc
cc: /mingw64/bin/cc.exe
$ cc --version
cc.exe (Rev2, Built by MSYS2 project) 8.3.0
Copyright (C) 2018 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
Really simple patch:
diff --git "a/Makefile" "b/Makefile"
index 063f50db..1d9f042e 100644
--- "a/Makefile"+++ "b/Makefile"@@ -288,7 +288,7 @@ CFLAGS := $(CFLAGS:-fPIC=)
# On Windows we need the shared library to be executable
else
# mingw?
-IS_MINGW := $(shell $(CC) --version | grep -i mingw | wc -l)+IS_MINGW := $(shell $(CC) --version | grep -i msys2 | wc -l)
ifeq ($(IS_MINGW),1)
EXT = dll
AR_EXT = lib
The text was updated successfully, but these errors were encountered:
Minor bug in the Makefile I found while building QEMU. The IS_MINGW check in the Makefile fails under MSYS2 MinGW-w64 because cc --version doesn't have mingw in the output anymore:
Really simple patch:
The text was updated successfully, but these errors were encountered: