Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix building on 10.6.8 #569

Merged
merged 1 commit into from Dec 15, 2015
Merged

fix building on 10.6.8 #569

merged 1 commit into from Dec 15, 2015

Conversation

rpinz
Copy link
Contributor

@rpinz rpinz commented Dec 15, 2015

added APPLE_CC to IS_APPLE test

added __APPLE_CC__ to IS_APPLE test
aquynh added a commit that referenced this pull request Dec 15, 2015
@aquynh aquynh merged commit 6e4827b into capstone-engine:master Dec 15, 2015
@aquynh
Copy link
Collaborator

aquynh commented Dec 15, 2015

merged, thanks!

@aquynh
Copy link
Collaborator

aquynh commented Dec 15, 2015

oops, this breaks OS X 10.10.5. i think the way you are combining "-e" with "grep" is not right/supported.

$ ./make.sh
....
ld: unknown option: -soname
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make: *** [libcapstone.so] Error 1

@fay59
Copy link
Contributor

fay59 commented Dec 15, 2015

The problem that I see is that recent OS Xes define both __apple_build_version__ and __APPLE_CC__, so the command returns 2 instead of 1. The fix is probably to check that $(IS_APPLE) is non-zero instead of exactly one.

Would you (@rpinz) mind fixing it?

@rpinz
Copy link
Contributor Author

rpinz commented Dec 16, 2015

Sure, commit incoming. Will always return boolean result if either is found.

#572

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants