Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make capstone compilable on freebsd10 with compile.sh #65

Closed
wants to merge 2 commits into from
Closed

Conversation

opntr
Copy link
Contributor

@opntr opntr commented Jan 15, 2014

Signed-off-by: Oliver Pinter oliver.pntr@gmail.com

Signed-off-by: Oliver Pinter <oliver.pntr@gmail.com>
@aquynh
Copy link
Collaborator

aquynh commented Jan 15, 2014

do we really need to specify "CC = clang" here for FreeBsd? i suppose that any compiler will work, no?

thanks.

Signed-off-by: Oliver Pinter <oliver.pntr@gmail.com>
@opntr
Copy link
Contributor Author

opntr commented Jan 15, 2014

In FreeBSD 10 only clang available by default. The other candidate are
cc which an alias to clang.

The change commited in my tree.

op@pandora-d ~> uname -sr
FreeBSD 10.0-PRERELEASE
op@pandora-d ~> which gcc
gcc: Command not found.
op@pandora-d ~> which cc
/usr/bin/cc
op@pandora-d ~> which clang
/usr/bin/clang

On 1/15/14, Nguyen Anh Quynh notifications@github.com wrote:

do we really need to specify "CC = clang" here for FreeBsd? i suppose that
any compiler will work, no?

thanks.


Reply to this email directly or view it on GitHub:
#65 (comment)

@aquynh
Copy link
Collaborator

aquynh commented Jan 16, 2014

perhaps a better approach is to make a switch to clang automatically when
gcc is not available, so we can support other environments, not only
FreeBsd10?

besides, we can keep new option of compile.sh that using "gmake", but
rename it to "bsd", so the same can work across all *BSD.

would you mind making these changes? then please send another pull request,
i will happily merge.

thanks!

On Thu, Jan 16, 2014 at 6:49 AM, opntr notifications@github.com wrote:

In FreeBSD 10 only clang available by default. The other candidate are
cc which an alias to clang.

The change commited in my tree.

op@pandora-d ~> uname -sr
FreeBSD 10.0-PRERELEASE
op@pandora-d ~> which gcc
gcc: Command not found.
op@pandora-d ~> which cc
/usr/bin/cc
op@pandora-d ~> which clang
/usr/bin/clang

On 1/15/14, Nguyen Anh Quynh notifications@github.com wrote:

do we really need to specify "CC = clang" here for FreeBsd? i suppose
that
any compiler will work, no?

thanks.


Reply to this email directly or view it on GitHub:
#65 (comment)


Reply to this email directly or view it on GitHubhttps://github.com//pull/65#issuecomment-32424212
.

@aquynh
Copy link
Collaborator

aquynh commented Jan 16, 2014

another thing: please working off the "next" branch, which will be merged and become next version very soon.

thanks.

@aquynh
Copy link
Collaborator

aquynh commented Jan 16, 2014

we can simply keep "CC ?= cc" regardless the platform, so default compiler will be used.

@opntr
Copy link
Contributor Author

opntr commented Jan 16, 2014

done

On 1/16/14, Nguyen Anh Quynh notifications@github.com wrote:

we can simply keep "CC ?= cc" regardless the platform, so default compiler
will be used.


Reply to this email directly or view it on GitHub:
#65 (comment)

@aquynh aquynh closed this Jan 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants