Skip to content
This repository has been archived by the owner on Jul 9, 2023. It is now read-only.

Game Pass International Support #1

Closed
aqw opened this issue Aug 15, 2018 · 32 comments
Closed

Game Pass International Support #1

aqw opened this issue Aug 15, 2018 · 32 comments
Labels

Comments

@aqw
Copy link
Collaborator

aqw commented Aug 15, 2018

Much of this content comes from pigskin/kodi-gamepass#313


A quick background for the uninitiated:

In 2017, the Game Pass Service was split between two streaming providers:

Game Pass Europe (WPP/Bruin)
Game Pass International (NeuLion)

Currently all developers of this library are in Europe, so only Game Pass Europe is supported. We are very interested in developers from Game Pass International regions getting involved in development and maintenance.

In theory, it should not be too difficult to get decent support for Game Pass International. Prior to 2017, NeuLion was the only streaming provider. Version 0.10.2 of aqw/xbmc-gamepass used that service. As a result, many of the devs have experience with the NeuLion service, and we can help provide some pointers.

However, not all is easy. Predictably, NeuLion has changed its APIs quite a bit since the split (likely concern over the competition), so it's not as easy as a quick code-resuscitation. There will likely be some new paths to blaze.

It is important that consumers of pigskin.py should be able to use the same API regardless of which service (Europe vs International) they are connecting to. This will be problematic at times, but looks to be doable.

Two places where you can borrow code from

  • pigskin.py from xbmc-gamepass 0.10.2
  • dav-sap did some work in the international-support-2017 branch of dav-sap/xbmc-gamepass
@aqw
Copy link
Collaborator Author

aqw commented Aug 21, 2018

@dav-sap says International Support is currently working in his fork, which is a /great/ start. Now the question is to examine what those changes are, and how we can weave together a coherent API that works against both services.

@r3dlobst3r
Copy link

I am willing to share a login for game pass international

@aqw
Copy link
Collaborator Author

aqw commented Aug 23, 2018

@r3dlobst3r Thanks for the offer. When it comes time to start integrating dev-sap's work into this library, I may ask for you to do some testing. :-)

@michlinux
Copy link

I have tried @dav-sap 's fork.. NFL network works but has issues (every 15secs or so it pauses and resumes after 2sec or so... ) However I am unable to get games to reply in any format... Looking in debug log its giving me a 403 error. Next live game I will check those... I have a full Gamepass account and currently in New Zealand, I am happy to help with testing, etc... I do know a bit of python however I am far from an expert, but I have no experience with writing addons for kodi.

@dav-sap
Copy link

dav-sap commented Aug 29, 2018 via email

@michlinux
Copy link

Yes I am using adaptive, as you stated before it does not work without it. so my memory must have been bad, as I timed between the "pauses" and it looks like its exactly 1min, might be 61secs.... I timed it for 5 times always the same. I grabbed part of debug log from when it does a pause.. I should clarify; the player doesn't pause, the screen goes black and I see a file flash like its starting a new file in the upper left, but its really fast. 1 second maybe, 2 max... most of that the screen is just black.
gamepass.log

@michlinux
Copy link

Tested on live games both with and without adaptive and neither work.

@dav-sap
Copy link

dav-sap commented Aug 31, 2018 via email

@michlinux
Copy link

Yep this is live game from today...
Logging starts from app launch to attempted live game play. Adaptive is on.
kodi.log

@aqw
Copy link
Collaborator Author

aqw commented Sep 11, 2018

Once #15 is done, then we can actively start working on this.

@dav-sap
Copy link

dav-sap commented Sep 11, 2018 via email

@aqw
Copy link
Collaborator Author

aqw commented Sep 11, 2018

@dav-sap I'm going to continue focusing on the new API. But, once that is done, I will gladly help you work on this. The great thing, is the way the new testing infrastructure works. Once you've figured out which URLs you're talking to, those responses can be saved in "cassettes" that the testing framework can replay. Then I can easily help working on this by just using those cassettes, rather than needing actual Game Pass International access myself.

It should make it a lot easier.

@dav-sap
Copy link

dav-sap commented Sep 15, 2018

i got replays to work. without using inputstream adaptive which is broken for kodi17.
So we have replays and nfl network live for now.
I believe the live games will work tomorrow now that i understood the problem. but can't promise anything. I committed the changes to my fork.

note: default inputstream adaptive for kodi17 is version 2.0.19, this issue (cookies not being sent in all requests) has been fixed in later versions. in kodi18 they use the latest version. need to manually update version so inputstream adaptive works

@michlinux
Copy link

Yes, they are working here as well, nicely done! Cheers m8, is adaptive bug the reason NFL network was doing the small freezes? - on a side note I have more free time now, so I can help with this project now.

@michlinux
Copy link

So it looks like Live is going to work... Monday Night game is getting ready to start, and its showing "The Game will start soon" screen.

@dav-sap
Copy link

dav-sap commented Sep 18, 2018 via email

@aqw aqw added the 0.4.0 label Sep 18, 2018
@aqw
Copy link
Collaborator Author

aqw commented Sep 18, 2018

@dav-sap Thanks for continuing to keep the International support alive. :-)

@michlinux You say you have time, eh? :-D Help's always appreciated. If your focus is international support, then @dav-sap is right that it's best to wait until I have the new API figured out (which hopefully won't be too much longer). If your interest is broader and feel comfortable working in Python, then find something you're interested in the issues and I can provide some direction. :-)

@r3dlobst3r
Copy link

@dav-sap @michlinux How were you able to get the addon to work in the new version of Kodi, with the updated version of input? Kodi will not allow me to enable it. Thanks!

@dav-sap
Copy link

dav-sap commented Sep 18, 2018 via email

@r3dlobst3r
Copy link

@dav-sap sorry i was referring to this part:
note: default inputstream adaptive for kodi17 is version 2.0.19, this issue (cookies not being sent in all requests) has been fixed in later versions. in kodi18 they use the latest version. need to manually update version so inputstream adaptive works

@dav-sap
Copy link

dav-sap commented Sep 18, 2018 via email

@r3dlobst3r
Copy link

Yeah, sorry for being too vague.

@dav-sap
Copy link

dav-sap commented Sep 18, 2018 via email

@r3dlobst3r
Copy link

Okay, thanks @dav-sap .

@michlinux
Copy link

@aqw You bet! I have "some" free time now starting this coming weekend. Im happy to help and my python skills are improving, so will see what I can do. cheers.

@aqw
Copy link
Collaborator Author

aqw commented Sep 19, 2018

@michlinux Great to hear. I'm actually leaving for a week-long vacation tomorrow, so I'll be taking a break during that period. But I'll be happy to answer any questions when I come back. :-)

@dav-sap
Copy link

dav-sap commented Aug 18, 2019

Hey all,
I can confirm international game pass works with https://github.com/aqw/xbmc-gamepass master code.
I used kodi 18 with inputstream adaptive. From what i read i think europe also has the problem they must use inputstream adaptive.
I checked: shows, nfl network live, live game, replays.

@Fooboss
Copy link

Fooboss commented Jan 12, 2020

@dav-sap Any way you could share how you installed the NFL Gamepass add-on into Kodi 18? Based on the discussion in this thread, I just tried updating to Kodi 18 but the NFL Gamepass add-on was reported as incompatible. Does it need to be installed manually somehow, rather than through the Kodi add-ons interface?

@CraigMack69
Copy link

If needed I can provide international gp account for a dev.

@Brandon1212b
Copy link

Is game pass international support working for this or https://github.com/pigskin/kodi-gamepass?

@jm-duke
Copy link
Contributor

jm-duke commented Sep 5, 2022

I don't know, if this still is an issue. Please see my comments in pigskin/kodi-gamepass#444

@jm-duke
Copy link
Contributor

jm-duke commented Jun 29, 2023

Closing this issue, as NFL has canceled the Gamepass service

@jm-duke jm-duke closed this as completed Jun 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

8 participants