Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test examples for Aframe, three.js, all features (GPS + marker + NFT) #9

Open
nicolocarpignoli opened this issue Mar 1, 2020 · 3 comments
Assignees
Projects

Comments

@nicolocarpignoli
Copy link
Member

nicolocarpignoli commented Mar 1, 2020

Because the file structure is changed, all the examples need to be tested (Aframe and Three.js).
We will report here if we found some bug or issue.
Note: test the master branch !
Thank you!

@kalwalt
Copy link
Member

kalwalt commented Mar 1, 2020

Tested the markers examples on desktop:

Three.js examples:

  • Most of the examples are displayed with a boxed canvas of width=640 and height=480 not
    fullscreen. So the model sometimes is showed shifted or distorted. If you open the browser dev console and resize suddenly the boxed canvas disappear, goes to fullscreen and the model is showed correctly. Of course is not the best situation, we should fix this behaviour.

  • marker-root.html example fails because:

Failed to load resource: the server responded with a status of 404 (Not Found)

  • parameters-tunning.html not works properly, probably something broken after removing aruco and tango code ( not sure also that worked in master...)

  • arjs-session.html the grid-plane is rotated ( need to be checked)

  • multimarkers learner and player does not works and won't be fixed now. We will see what to do with them....

Aframe examples:

Aframe examples are not affected by the fullscreen issue as for the Three.js's because the canvas is not boxed.

  • minimal.html because it use the <a-marker-camera> the content is shifted even if the position setting is correct. We should change the code to use an entity camera instead.

@nicolocarpignoli
Copy link
Member Author

About three.js issue, I encountered this before, working on first NFT cases on AR.js. It should be fixed with latest modify with setTimeout. You can pull and try 'basic.html' example. Let me know. If it works, we can replicate it for every three.js example - anyway, it's just a matter of 'onResize' not being called at the right time.

@kalwalt
Copy link
Member

kalwalt commented Mar 1, 2020

i saw your changes i will see tomorrow, Thanks!

@nicolocarpignoli nicolocarpignoli moved this from TODO to WIP in v3 Mar 2, 2020
@nicolocarpignoli nicolocarpignoli moved this from WIP to DONE in v3 Mar 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
v3
  
DONE
Development

No branches or pull requests

2 participants