-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong elliptic filter ripple configuration #12
Comments
Hi! The code is based on this wonderful pdf: http://eceweb1.rutgers.edu/~orfanidi/ece521/notes.pdf. Take a look at derivations at page 2. For instance, Also, in FiltersForm the code is: var ripplePassDb = Utils.Scale.ToDecibel(1 / deltaPass); because |
Ah OK. So parameter "rippleStop" means the stopband ripple, in decibels (stopbandRipple) and parameter "ripplePass" means the stopband attenuation, in decibels (stopbandAttenuation)? |
Not sure if I understood you correctly. Fig.1 at page 2 from the pdf should help (I'm using the same notation): Passband gain:
This is what the notation is in the pdf. I like the term 'attenuation' better because this value defines the amplitude loss (not the max amplitude of fluctuations in stopband) according to Fig.1. And the passband gain (ripple) here means also the max amplitude loss compared to level=1.0. Often it has slightly different meaning - illustrated here (when the center of oscillations is at level 1.0 : |
Thanks a lot! Yes, the different terms make it difficult to learn... |
The elliptic filter ripple configuration in FiltersForm.AnalyzeEllipticFilter is converted to magnitude Db. But in PrototypeElliptic.Poles and PrototypeElliptic.Zeros it is converted as power Db. So my suggestion is not to use Db here. Or I am wrong?
The text was updated successfully, but these errors were encountered: