Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the option to customize the "stats" attribute #67

Closed
danilofuchs opened this issue Mar 10, 2019 · 7 comments · Fixed by #182
Closed

Add the option to customize the "stats" attribute #67

danilofuchs opened this issue Mar 10, 2019 · 7 comments · Fixed by #182
Labels
🏗️ enhancement New feature or request :octocat: good first issue Good for newcomers

Comments

@danilofuchs
Copy link
Contributor

There should be an option to customize webpack's stats attribute.
To solve this issue on mini-css-extract-plugin, it is required to change the property.

@with-heart with-heart added the 🏗️ enhancement New feature or request label Jul 2, 2019
@with-heart
Copy link
Collaborator

Hi @danilofuchs, is this still an issue for you? Have you found a workaround or created your own function for handling this change?

@danilofuchs
Copy link
Contributor Author

As I'm currently using Styled Components, not Sass, I haven't faced this issue in some time. But to my understanding, this is still a major issue for Sass users, but a simple customize-cra function is viable to those still needing to fix this.

@danilofuchs
Copy link
Contributor Author

If you think this is out of the scope of this project, I'm happy to close the issue and propose a user-made solution

@with-heart
Copy link
Collaborator

I'm fine with that being added, if anyone would like to open a PR.

@with-heart with-heart added the :octocat: good first issue Good for newcomers label Nov 6, 2019
@danilofuchs
Copy link
Contributor Author

I'll work on it!

@with-heart
Copy link
Collaborator

Thank you! Sorry for taking so long to say that 😆 looking forward to it!

@danilofuchs
Copy link
Contributor Author

I have been working on it, but I can't seem to make create-react-app respect the config. I think their implementation of error / warning handling is overriding webpack's actions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏗️ enhancement New feature or request :octocat: good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants