Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github.com/apcera/termtables is no longer available, breaking main.go and travis CI #90

Closed
troyspencer opened this issue Aug 13, 2019 · 3 comments · Fixed by #101
Closed

Comments

@troyspencer
Copy link
Contributor

github.com/apcera/termtables is no longer available, so go get -t -v ./... fails.

@troyspencer
Copy link
Contributor Author

This is fixed in #89 by vendoring termtables.

@creekorful
Copy link
Contributor

Hello @troyspencer, I have made a PR with a fix little bit different from the one that you've proposed, can you check and it and tell me what you think?

Thank in advance

@troyspencer
Copy link
Contributor Author

Hello @troyspencer, I have made a PR with a fix little bit different from the one that you've proposed, can you check and it and tell me what you think?

Thank in advance

Looks good. I did the vendoring maybe a day after the dependency went offline as I didn't feel like supporting termtables myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants