Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node RoundTriping Json & Identity Cleanup #146

Open
3 tasks
araddon opened this issue Dec 20, 2016 · 0 comments
Open
3 tasks

Node RoundTriping Json & Identity Cleanup #146

araddon opened this issue Dec 20, 2016 · 0 comments
Projects

Comments

@araddon
Copy link
Owner

araddon commented Dec 20, 2016

In implementation of the new Node -> Expr -> Json we should add round-tripping to our tests.

Additionally, we are having problems with left.right identities.

  • Ensure we have a large suite of tests that round-trip
  • fix left.right including in expr
  • replace current Protobuf with expr.ToPb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

1 participant