Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Key exposed #13

Closed
suvadityamuk opened this issue Jun 14, 2021 · 4 comments · Fixed by #14
Closed

API Key exposed #13

suvadityamuk opened this issue Jun 14, 2021 · 4 comments · Fixed by #14

Comments

@suvadityamuk
Copy link

API keys exposed in covid-tracker-master/lib/network-requests/api_service.dart. Please check and rectify.

@arafaysaleem
Copy link
Owner

Thanks for pointing it out. I made this project as a beginner and never took care of this thing. I'll convert it into an environment variable right away.

@suvadityamuk
Copy link
Author

suvadityamuk commented Jun 14, 2021

Also, just saying. Might wanna check this out here

@arafaysaleem
Copy link
Owner

Since the project was open sourced with the intent of allowing people to take inspiration, it's fine if someone clones it. The licensing was quite open.

@suvadityamuk
Copy link
Author

Sure, just letting you know. But, the license was deleted, which was in contravention to the license rules itself. That's all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants