Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] Install Zoo as a package #107

Closed
brendenpetersen opened this issue Sep 25, 2020 · 6 comments
Closed

[feature request] Install Zoo as a package #107

brendenpetersen opened this issue Sep 25, 2020 · 6 comments
Labels
enhancement New feature or request

Comments

@brendenpetersen
Copy link

It would be great to be able to install Zoo as a package/module (even better would be one registered to PyPI) so that I can access things like utils from other projects.

Until then I think my options are:

  1. Use sys.path.append(ZOO_REPOSITORY_ROOT).
  2. Add my own setup.py.
  3. Copy/link the code to site-packages.

None of these are great options when I'd like my project to view Zoo as a dependency.

@araffin
Copy link
Owner

araffin commented Sep 28, 2020

Hello,
I understand your issue. However, the rl zoo is not really meant to be a package.
My main concern is that the current repo is quite big because of the trained agents, which is not the case anymore in the newest version of the zoo: https://github.com/DLR-RM/rl-baselines3-zoo.

None of these are great options when I'd like my project to view Zoo as a dependency.

If you have a custom version of the zoo that is online (with a setup.py, you can always write it as a pip dependency:

pip install git+https://github.com/DLR-RM/rl-baselines3-zoo

would work ;) (with a proper setup.py)

@araffin araffin added the enhancement New feature or request label Sep 28, 2020
@brendenpetersen
Copy link
Author

brendenpetersen commented Sep 28, 2020

@araffin Thanks for the reply. Yes, I was afraid that was going to be your answer 😜 Though it's understandable given that there is data in the repo. I was just hoping to be able to use it as a dependency without maintaining a fork of zoo with an added setup.py.

When you say "with a proper setup.py", do you mean one I'd write inside (a fork of) zoo? Or are you saying I could mangle my own project's setup.py to install zoo as a package (which doesn't have setup.py). If the latter is possible, that would work for me.

Also, I was not aware of https://github.com/DLR-RM/rl-baselines3-zoo. Or even stable-baselines3. Thanks!

@araffin
Copy link
Owner

araffin commented Sep 29, 2020

i meant a setup.py in your fork.

Also, I was not aware of https://github.com/DLR-RM/rl-baselines3-zoo. Or even stable-baselines3.

oh...we should advertise it more, we are close to a 1.0 (the library is already usable, we mostly need to polish several aspects)

@araffin
Copy link
Owner

araffin commented Nov 13, 2020

Good news for you, I'll migrate most of the utils (wrappers and callbacks) to the sb3 contrib package ;)

@brendenpetersen
Copy link
Author

@araffin Awesome! Thanks so much for letting me know!!

@araffin
Copy link
Owner

araffin commented Oct 4, 2022

now done in now done in https://github.com/DLR-RM/rl-baselines3-zoo/releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants