Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep track of all token holders in Token Manager #53

Closed
izqui opened this issue Jan 4, 2018 · 2 comments · Fixed by #55
Closed

Keep track of all token holders in Token Manager #53

izqui opened this issue Jan 4, 2018 · 2 comments · Fixed by #55

Comments

@izqui
Copy link
Contributor

izqui commented Jan 4, 2018

This is an extremely short term solution that will allow the Token Manager frontend to load much quicker.

Given #51, which allows to have boards with just tokens, a way to quickly a list of all token holders is important.

Adding this will add ~45k gas every time a new holder is added. Expensive but might be worth it in UX terms in the short term.

@lkngtn
Copy link
Contributor

lkngtn commented Jan 4, 2018

What would the longer term solution be that is more gas efficient?

@izqui
Copy link
Contributor Author

izqui commented Jan 5, 2018

Right now the frontend filters all transfer events for the token in the blockchain to compute the list of holders locally, this is probably going to be too resource hungry and not be really performant, specially in heavily transferred tokens.

The super cool long term solution is the ability to have a 'shared cached state' of apps, so the state is only computed once and then others can use it while minimizing the amount of trust on the entity that serves the state. We will do a lot of effort on this front for v0.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants