Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update solidity-coverage to v0.7 #255

Closed
wants to merge 2 commits into from
Closed

Update solidity-coverage to v0.7 #255

wants to merge 2 commits into from

Conversation

bingen
Copy link
Contributor

@bingen bingen commented Mar 4, 2020 •
edited

Fixes #86

@bingen bingen self-assigned this Mar 4, 2020
@facuspagnuolo
Copy link
Contributor

I don't see a CI job for this, do you know why?

sohkai
sohkai reviewed Mar 6, 2020
View reviewed changes
.travis.yml Outdated Show resolved Hide resolved
@facuspagnuolo @sohkai
chore: fix travis yaml file
4e1d02f 
Co-Authored-By: Brett Sun <qisheng.brett.sun@gmail.com>
@facuspagnuolo
Copy link
Contributor

For some reason the @skip-coverage notation is not working

@bingen
Copy link
Contributor Author

bingen commented Mar 9, 2020

For some reason the @skip-coverage notation is not working

Do you mean in the CI? Because in locally it was working for me. I don't see gas tests in the coverage task either. Where are you seeing them?

@facuspagnuolo facuspagnuolo changed the base branch from master to development March 16, 2020 13:51
@facuspagnuolo facuspagnuolo changed the base branch from development to master March 16, 2020 13:51
facuspagnuolo
facuspagnuolo reviewed Mar 16, 2020
View reviewed changes
Copy link
Contributor

@facuspagnuolo facuspagnuolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see how we can handle the travis timeout, not sure if there is a way to instrument the code in batches

@bingen
Copy link
Contributor Author

bingen commented Mar 16, 2020

Let's see how we can handle the travis timeout, not sure if there is a way to instrument the code in batches

Being coverage I don't know how we can batch it. What I would do for now is to remove the travis job and merge this PR, so at least we can run coverage locally.

@sohkai
Copy link
Contributor

sohkai commented Mar 17, 2020 •
edited

Being coverage I don't know how we can batch it. What I would do for now is to remove the travis job and merge this PR, so at least we can run coverage locally.

We could do a quick experiment or two using lcov-result-merger (see aragon-apps for usage). I think it even supports merging coverage results across different runs if the runs overlap on the same files.

@facuspagnuolo
Copy link
Contributor

Closing this for now

@facuspagnuolo facuspagnuolo deleted the coverage_0.7 branch October 13, 2020 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sohkai sohkai sohkai left review comments

@facuspagnuolo facuspagnuolo facuspagnuolo left review comments

@izqui izqui Awaiting requested review from izqui

Assignees

@bingen bingen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chore: Add coverage measure tool
3 participants
@bingen @facuspagnuolo @sohkai