Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tree: Write full-coverage unit tests #94

Closed
facuspagnuolo opened this issue Aug 6, 2019 · 0 comments · Fixed by #104
Closed

Tree: Write full-coverage unit tests #94

facuspagnuolo opened this issue Aug 6, 2019 · 0 comments · Fixed by #104
Assignees
Labels
component:tests Tests related requirements
Milestone

Comments

@facuspagnuolo
Copy link
Contributor

Please follow the convention used for the JurorsRegistry tests, some of them are:

  • Avoid mocking unnecessarily, only when there is no other option
  • Use test-helpers module provided by @aragon
  • Implement reusable helpers stuff instead of custom non-exported functions
  • Use let scoped variables instead of properties to define test variables
@facuspagnuolo facuspagnuolo added the component:tests Tests related requirements label Aug 6, 2019
@facuspagnuolo facuspagnuolo self-assigned this Aug 12, 2019
@facuspagnuolo facuspagnuolo modified the milestones: Sprint 26, Sprint 27 Aug 12, 2019
@facuspagnuolo facuspagnuolo changed the title Write full-coverage unit tests for HexSumTree Tree: Write full-coverage unit tests Sep 19, 2019
@izqui izqui modified the milestones: Sprint 27, Freeze #1 Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:tests Tests related requirements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants