Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Court: Fix jurors burned tokens accounting #99

Closed
facuspagnuolo opened this issue Aug 9, 2019 · 0 comments
Closed

Court: Fix jurors burned tokens accounting #99

facuspagnuolo opened this issue Aug 9, 2019 · 0 comments
Assignees
Labels
bug Something isn't working component:contracts Contracts related requirements
Milestone

Comments

@facuspagnuolo
Copy link
Contributor

For regular appeal rounds, tokens of the slashed jurors are burned and re-distributed between the winning jurors. OTOH, for final appeal rounds, we burn the tokens of all the jurors participating in it and then re-assign the tokens of the winning jurors along with re-distributing the tokens of the losing jurors between the winning ones.

The problem is that the burn balance is never decreased. Ofc, this is not harmful but accounting does not match correctly.

I propose introducing a new term to handle this since it is not actually a tokens burn (burned tokens are supposed to be burned forever). We should model sth similar to a "lock" and differentiate it from the actual locking we have in the jurors registry currently.

@facuspagnuolo facuspagnuolo added bug Something isn't working component:contracts Contracts related requirements labels Aug 9, 2019
@sohkai sohkai assigned facuspagnuolo and unassigned facuspagnuolo Aug 9, 2019
@sohkai sohkai added this to the Sprint 26 milestone Aug 9, 2019
@facuspagnuolo facuspagnuolo changed the title Fix jurors burned tokens accounting Court: Fix jurors burned tokens accounting Sep 19, 2019
@izqui izqui modified the milestones: Sprint 26, Freeze #1 Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component:contracts Contracts related requirements
Projects
None yet
Development

No branches or pull requests

3 participants