Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinning Aragon Apps #8

Closed
3 tasks done
luisivan opened this issue Oct 8, 2018 · 3 comments
Closed
3 tasks done

Pinning Aragon Apps #8

luisivan opened this issue Oct 8, 2018 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@luisivan
Copy link
Contributor

luisivan commented Oct 8, 2018

  • Sniff requests with Muon
  • Cache the apps with ipfs-api
  • Remove cached content if path not accessed for more than a week
@luisivan luisivan self-assigned this Oct 8, 2018
@luisivan luisivan added the enhancement New feature or request label Oct 8, 2018
@izqui
Copy link

izqui commented Oct 9, 2018

I still need to test it, but I think as it is implemented currently a malicious app could make requests to localhost:8080/ipfs/[hash] and pin any content they want on the user's machine.

@luisivan
Copy link
Contributor Author

luisivan commented Oct 9, 2018

Correct. Any workaround you can think of @izqui? I don't think this is a huge attack vector for now

@izqui
Copy link

izqui commented Oct 9, 2018

Yep, not a huge problem but something to keep in mind. A workaround would be for Aragon Desktop to directly use aragon.js to check what apps a DAO has a pin only the content for those, or for us to keep a list of IPFS hashes that should be pinned and pin those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants