Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrapper: AragonApps w/o permissions are not detected #201

Open
ewingrj opened this issue Oct 26, 2018 · 3 comments
Open

Wrapper: AragonApps w/o permissions are not detected #201

ewingrj opened this issue Oct 26, 2018 · 3 comments
Labels
enhancement New feature or request

Comments

@ewingrj
Copy link
Contributor

ewingrj commented Oct 26, 2018

The wrapper is using the permissions observable to create the apps observable. If I add a new app w/o setting any permissions, it will not be added to the apps stream.

@sohkai
Copy link
Contributor

sohkai commented Oct 26, 2018

@perissology An app is technically not installed until there are references to it in the ACL, as a app with no permissions set is effectively a useless app (https://hack.aragon.org/docs/cli-usage.html#dao-install) (assuming roles are being used).

@ewingrj
Copy link
Contributor Author

ewingrj commented Oct 26, 2018

Is the assumption when installing a new app to an existing dao that a kit will be used & the permissions setup via the kit?

With the permissions app now available, maybe it makes sense to show un-permissioned apps there?

@sohkai
Copy link
Contributor

sohkai commented Nov 16, 2018

@perissology Hmm... maybe in the App Center, and it could lead you to initialize it and assign permissions. Technically we do have enough information from the SetApp and NewAppProxy events to know if you have an orphaned app without permissions.

The general assumption is that you'll be using some sort of kit / bundler contract that will create, initialize, and assign the initial permissions when installing most apps though.

@sohkai sohkai added the enhancement New feature or request label Nov 16, 2018
@stale stale bot added the abandoned label May 31, 2019
@stale stale bot closed this as completed Jun 7, 2019
@sohkai sohkai reopened this Jul 3, 2019
@stale stale bot removed the abandoned label Jul 3, 2019
@aragon aragon deleted a comment from stale bot Dec 2, 2019
@sohkai sohkai changed the title aragon-wrapper: AragonApps w/o permissions are not detected wrapper: AragonApps w/o permissions are not detected Mar 17, 2020
@sohkai sohkai changed the title wrapper: AragonApps w/o permissions are not detected Wrapper: AragonApps w/o permissions are not detected Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants