Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboarding: add Agent as optional module #1018

Merged
merged 2 commits into from Sep 10, 2019

Conversation

@sohkai
Copy link
Member

commented Sep 10, 2019

Screen Shot 2019-09-10 at 4 05 42 PM

Passes the optional modules to each template's prepareTransactions().

sohkai added 2 commits Sep 10, 2019

@auto-assign auto-assign bot requested review from AquiGorka and bpierre Sep 10, 2019

@bpierre
Copy link
Member

left a comment

💥

>
<Checkbox
checked={templateOptionalModules[appName]}
onChange={() => {

This comment has been minimized.

Copy link
@sohkai

sohkai Sep 10, 2019

Author Member

@bpierre I don't know if there's a way to avoid this function declaration without going too far out of our way. I think it's fine like this?

This comment has been minimized.

Copy link
@bpierre

bpierre Sep 10, 2019

Member

Yes totally fine, we are almost at the last level of the tree +1

@sohkai sohkai merged commit c1d6e54 into master Sep 10, 2019

8 of 9 checks passed

build build
Details
install install
Details
lint lint
Details
now Deployment has failed
Details
License Compliance All checks passed.
Details
WIP Ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@delete-merged-branch delete-merged-branch bot deleted the onboarding-agent branch Sep 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.