Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LocalIdentity: polish and small fixes #677

Merged
merged 9 commits into from Apr 8, 2019

Conversation

Projects
None yet
3 participants
@sohkai
Copy link
Member

sohkai commented Apr 4, 2019

Most important fix is to add the correct network to the IdentityBadges, but a couple of other small changes / improvements.

sohkai added some commits Apr 4, 2019

@sohkai sohkai requested review from bpierre and 2color Apr 4, 2019

@@ -85,8 +87,8 @@ const LocalIdentities = ({
<StyledExport
label="Export labels"
mode="secondary"
download={`aragon-labels_${today}.json`}
href={href}
download={`aragon-${locator.dao}_labels_${today}.json`}

This comment has been minimized.

Copy link
@2color

2color Apr 8, 2019

Contributor

Nice!

@2color

This comment has been minimized.

Copy link
Contributor

2color commented Apr 8, 2019

LGTM so far.

sohkai added some commits Apr 8, 2019

@sohkai sohkai marked this pull request as ready for review Apr 8, 2019

@sohkai sohkai requested a review from 2color Apr 8, 2019

@sohkai

This comment has been minimized.

Copy link
Member Author

sohkai commented Apr 8, 2019

@bpierre @2color Ready for review :).

@2color

2color approved these changes Apr 8, 2019

Copy link
Contributor

2color left a comment

LGTM

@bpierre

bpierre approved these changes Apr 8, 2019

Copy link
Member

bpierre left a comment

💯

@@ -1,5 +1,6 @@
import React from 'react'
import PropTypes from 'prop-types'
import keycodes from '../../keycodes'

This comment has been minimized.

Copy link
@bpierre

bpierre Apr 8, 2019

Member

🙆‍♂️

@@ -27,11 +22,11 @@ LocalIdentityModal.propTypes = {

const Modal = ({ address, label, onCancel, onSave }) => {
const [action, setAction] = React.useState()

This comment has been minimized.

Copy link
@bpierre

bpierre Apr 8, 2019

Member

Not related to this PR, but I think it could be a good practice to always set a default for useState(), even if we want undefined.

This comment has been minimized.

Copy link
@sohkai

sohkai Apr 8, 2019

Author Member

Fixed in 5b78370.

@@ -110,7 +107,7 @@ const Wrap = styled.div`
padding: 16px 32px;
max-width: 50vw;
/* wide identity badge + paddings */
min-width: calc(400px + 32px * 2);
min-width: ${400 + 32 * 2}px;

This comment has been minimized.

Copy link
@bpierre

@sohkai sohkai merged commit a6e3a5c into master Apr 8, 2019

1 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
license/cla Contributor License Agreement is signed.
Details

@sohkai sohkai deleted the localidentity-polish branch Apr 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.