New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LocalIdentity: polish and small fixes #677
Conversation
@@ -85,8 +87,8 @@ const LocalIdentities = ({ | |||
<StyledExport | |||
label="Export labels" | |||
mode="secondary" | |||
download={`aragon-labels_${today}.json`} | |||
href={href} | |||
download={`aragon-${locator.dao}_labels_${today}.json`} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
LGTM so far. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
@@ -1,5 +1,6 @@ | |||
import React from 'react' | |||
import PropTypes from 'prop-types' | |||
import keycodes from '../../keycodes' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙆♂️
@@ -27,11 +22,11 @@ LocalIdentityModal.propTypes = { | |||
|
|||
const Modal = ({ address, label, onCancel, onSave }) => { | |||
const [action, setAction] = React.useState() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not related to this PR, but I think it could be a good practice to always set a default for useState()
, even if we want undefined
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 5b78370.
@@ -110,7 +107,7 @@ const Wrap = styled.div` | |||
padding: 16px 32px; | |||
max-width: 50vw; | |||
/* wide identity badge + paddings */ | |||
min-width: calc(400px + 32px * 2); | |||
min-width: ${400 + 32 * 2}px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Most important fix is to add the correct network to the
IdentityBadge
s, but a couple of other small changes / improvements.