Share identities via link #775

AquiGorka · 2019-05-09T13:43:17Z

Share local identities via link (and import them too 😄 )

Summary

When clicking on share the selected identities are "bundled" into a link (base64 encoded)
When the user opens up the link a new modal will show (when the wrapper instance exists and the labels have been parsed from the url)
The user can choose which items to save. This implementation will remove the user's existing local identities and override with the selected ones.

How to test

Use the branch corresponding to this pull request git fetch && git checkout feature/share-identities
Install the dependencies and start the server npm i && npm run
Open http://localhost:3000/ in your browser and load an organization (rinkeby).

Pending

Animations
- To show the Save modal
- To hide the Save modal
- To hide the Share modal when link has been copied (or not, decision needed)
- To show the Preferences modal when saving (or maybe not, decision needed)
Loader when "saving" shared labels

bpierre · 2019-05-10T09:50:31Z

@AquiGorka is it ready to be reviewed? Asking because of the “pending” list.

AquiGorka · 2019-05-10T10:13:53Z

@bpierre after discussing with @dizzypaty about the animations (and how the Save labels modal is part of Preferences) I will make some big changes to this code (mostly on how and where to render) so the code that shares and imports will likely stay the same.
Having said all that, early reviews are always helpful.

bpierre · 2019-05-10T10:14:20Z

@dizzypaty @AquiGorka I’m wondering if we shouldn’t make it more explicit that we are importing data coming from the outside on the importing screen? Maybe using the word “importing” instead of “saving”, or by displaying a warning message? Otherwise a click on the “save” button might seem like a non-risky action, if the user assumes the data displayed is theirs.

AquiGorka · 2019-05-10T10:25:25Z

"Save external custom labels"?

AquiGorka · 2019-05-10T14:58:25Z

@bpierre changes done, ready for review ✅

dizzypaty · 2019-05-14T19:08:20Z

Loading screen when saving shared custom labels

LoadingRing component

sohkai · 2019-05-15T09:42:58Z

@AquiGorka I've merged with master, noticed a few things:

The "Export" button is still clickable if no identities are selected, even though the cursor seems to indicate it's been deactivated
On importing, the "confirm removal" modal appears (this behaviour doesn't exist on master so might be due to some API differences during the merge)

bpierre

Looking good! I only have one important issue with unicode characters. Also, shouldn’t we have the same importation screen when we import from a file?

src/components/Preferences/LocalIdentities.js

bpierre · 2019-05-15T14:55:58Z

src/components/Preferences/LocalIdentities.js

-    const handleDownload = useCallback(() => {
+  useEffect(() => {
+    if (shareModalOpen) {
+      setTimeout(() => inputRef.current.focus(), 0)


Thank you, got this gem from your code 😄

src/components/Preferences/LocalIdentities.js

sohkai

Looks good, confirmed the fixes :).

Left a number of clean up / API comments that we don't need to fix immediately for this release.

src/components/Preferences/LocalIdentities.js

src/components/Preferences/Preferences.js

src/components/Preferences/SharedLabels.js

src/hooks.js

sohkai · 2019-05-15T15:58:20Z

src/hooks.js

+    }
+  }, [])
+
+  return { isSharedLink, setIsSharedLink, sharedLabels, removeSharedLink }


Rather than directly exposing setIsSharedLink and removeSharedLink, it seems like we could roll them into a single API?

And could we detect isSharedLink from a non-null sharedLabels?

sohkai · 2019-05-15T16:00:04Z

src/hooks.js

+    ],
+    [selected]
+  )
+  return { selected, setSelected, allSelected, someSelected }


This also feels like we could include some of the toggling functionality (for toggling all and individual ids) to avoid repeating it.

Should we also use this directly in SelectableLocalIdentity?

sohkai

Functionality all looks good to me, great job @AquiGorka! Let's work on the other review comments after this has been merged :).

Co-Authored-By: Brett Sun <qisheng.brett.sun@gmail.com>

AquiGorka requested review from bpierre, 2color, sohkai, dizzypaty and delfipolito May 9, 2019 13:43

AquiGorka changed the base branch from master to feature/granular-export-labels May 9, 2019 13:44

luisivan mentioned this pull request May 9, 2019

Link for sharing labels aragonone/product#72

Closed

AquiGorka force-pushed the feature/share-identities branch 2 times, most recently from b17f2e6 to 93e8bc0 Compare May 10, 2019 08:52

AquiGorka force-pushed the feature/share-identities branch 2 times, most recently from 20bce07 to c5eb87a Compare May 10, 2019 14:57

AquiGorka changed the base branch from feature/granular-export-labels to master May 13, 2019 09:30

AquiGorka added 13 commits May 13, 2019 12:02

LocalIdentities: add shareable functionality

074a657

LocalIdentities: cleanup prop type declarations

fb689de

LocalIdentities: add memoization to handlers

f5ef105

LocalIdentities: improve sharing link

0cd7a44

SaveLocalIdentities: add component

06effec

Wrapper: add save local identities modal

bb17956

SaveLocalIdentities: add copy

5157ddb

LocalIdentities: add visual designs

5148aa4

SaveLocalIdentities: add visual designs

dbee5aa

SaveLocalIdentities: add toast on save

a091034

SaveLocalIdentities: fix on save process

e2153f2

SaveLocalIdentities: split logic into independent components

706da3c

SaveLocalIdentities: fix dependencies on callbacks

172d4a7

AquiGorka added 2 commits May 13, 2019 12:06

SharedLabels: add component

930b7cb

Refactor preferences to render share labels & local identities

354dd62

AquiGorka force-pushed the feature/share-identities branch 2 times, most recently from 8d8ff3d to 354dd62 Compare May 13, 2019 10:13

sohkai mentioned this pull request May 13, 2019

0.7.2 aragonone/product#102

Closed

20 tasks

Merge branch 'master' into feature/share-identities

40d18f9

AquiGorka added 4 commits May 15, 2019 15:38

EmptyLocalIdentities: add name to function for debugging

0cfa669

LocalIdentities: add names to anon functions and fix prop types

b7df77e

SharedLocalIdentities: add loading ring when saving

f6af805

LocalIdentities: align remove button to the left

e671fb4

bpierre reviewed May 15, 2019

View reviewed changes

sohkai approved these changes May 15, 2019

View reviewed changes

Fix the base64 conversion with unicode characters

ef5b877

sohkai approved these changes May 15, 2019

View reviewed changes

AquiGorka and others added 3 commits May 16, 2019 09:34

SharedLabels: improve copy

2cda29d

Co-Authored-By: Brett Sun <qisheng.brett.sun@gmail.com>

SharedLabels: refactor code syntax

b35e490

Co-Authored-By: Brett Sun <qisheng.brett.sun@gmail.com>

LocalIdentities: add useSelected hook and pass down props

e1c47a4

AquiGorka force-pushed the feature/share-identities branch from 2ce17df to e1c47a4 Compare May 16, 2019 08:02

AquiGorka added 6 commits May 16, 2019 10:05

LocalIdentities: remove unnecessary styled component

9b45abc

Preferences: remove deps on useEsc

ae9da07

Preferences: add tabbed navigation at this level

1302734

LocalIdentities: remove tabbed navigation at this level

9e4dc97

SharedLabels: add fancy quotes

6985771

Merge branch 'master' into feature/share-identities

66466f2

AquiGorka merged commit c7f2623 into master May 16, 2019

AquiGorka deleted the feature/share-identities branch May 16, 2019 09:03

AquiGorka mentioned this pull request May 16, 2019

Pending items Share custom labels via link #785

Closed

4 tasks

luisivan mentioned this pull request May 24, 2019

Improvements to the custom labels share link aragonone/product#117

Closed

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Share identities via link #775

Share identities via link #775

AquiGorka commented May 9, 2019 •

edited

bpierre commented May 10, 2019

AquiGorka commented May 10, 2019 •

edited

bpierre commented May 10, 2019

AquiGorka commented May 10, 2019

AquiGorka commented May 10, 2019

dizzypaty commented May 14, 2019

sohkai commented May 15, 2019

bpierre left a comment

bpierre May 15, 2019

AquiGorka May 16, 2019

sohkai left a comment

sohkai May 15, 2019

sohkai May 15, 2019 •

edited

sohkai left a comment

Share identities via link #775

Share identities via link #775

Conversation

AquiGorka commented May 9, 2019 • edited

Share local identities via link (and import them too 😄 )

Summary

How to test

Pending

bpierre commented May 10, 2019

AquiGorka commented May 10, 2019 • edited

bpierre commented May 10, 2019

AquiGorka commented May 10, 2019

AquiGorka commented May 10, 2019

dizzypaty commented May 14, 2019

Loading screen when saving shared custom labels

sohkai commented May 15, 2019

bpierre left a comment

Choose a reason for hiding this comment

bpierre May 15, 2019

Choose a reason for hiding this comment

AquiGorka May 16, 2019

Choose a reason for hiding this comment

sohkai left a comment

Choose a reason for hiding this comment

sohkai May 15, 2019

Choose a reason for hiding this comment

sohkai May 15, 2019 • edited

Choose a reason for hiding this comment

sohkai left a comment

Choose a reason for hiding this comment

AquiGorka commented May 9, 2019 •

edited

AquiGorka commented May 10, 2019 •

edited

sohkai May 15, 2019 •

edited