Worker: reorganize components and refactor error handling #863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sohkai
commented
Jul 8, 2019
| }) | ||
|
|
||
| // Reset pool | ||
| this.workers.clear() |
There was a problem hiding this comment.
Note that this is not strictly necessary based on our usage (we create a new instance on initialization), but it does feel safer :)
sohkai
commented
Jul 8, 2019
| 'error', | ||
| error => { | ||
| console.error('Error from worker for ${name} (loaded from ${scriptUrl}):', error.message, error) | ||
| window.parent.postMessage( |
There was a problem hiding this comment.
The big change here was to avoid passing the error through postMessage. Errors can't be copied through the Structured Cloning algorithm
sohkai
commented
Jul 8, 2019
| false | ||
| ) | ||
| window.addEventListener('message', ({ data, source }) => { | ||
| if (source === window.parent) { |
There was a problem hiding this comment.
This is also important; we need to check the source of the message, otherwise it could be another window sending information to this iframe.
AquiGorka
approved these changes
Jul 10, 2019
|
Tested it with the production build locally and nothing seems out of the ordinary :). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Puts all of the WebWorker related components into
worker/.removeWorker()API (I think it's a bit more clear)