SignerPanel: adjust for new styles #920
Conversation
| <ButtonLink onClick={onRequestEnable}>enable</ButtonLink>{' '} | ||
| <ButtonText | ||
| onClick={onRequestEnable} | ||
| horizontalPadding="none" |
There was a problem hiding this comment.
Maybe we should have horizontalPadding=none by default on ButtonText 🤔
There was a problem hiding this comment.
Or provide an inline mode, since I find myself using it quite a lot in text :).
But yeah, I've almost always had to disable the horizontal padding when I need this component.
| onClick={onRequestEnable} | ||
| horizontalPadding="none" | ||
| css={` | ||
| padding: 0; |
There was a problem hiding this comment.
…or maybe we need two components: ButtonText would be without any padding, horizontal nor vertical, and Button would have a text mode, with a way to disable the padding on one or both sides.
sohkai
force-pushed
the
newstyle-signerpanel
branch
from
1b8201a
to
676ee55
Compare
|
All the Panel modes are looking great! ✨ For the case where we have multiple tx to sign, I've added to the 'Client' figma file a variation of the feedback module that is consistent with how we present multiple tx signing on the new on-boarding:
Perhaps this is something that we can do after the launch, on another round of polishing. |
|
@dizzypaty Let's do this separately, we would also have to handle the case where someone updates their organization through four transactions (if you had direct permissions to do so in the Kernel), and stacking four of those may look a bit odd. |
…tions * origin/newstyle: MenuPanel tweaks (#933) Home redesign (#934) SignerPanel: consolidate external transaction props into intent object (#931) useLocalIdentity: handle remove case (#930) Add AppInternal to manage the layout logic of internal apps (#932) MenuPanel: adjust for new styles (#923) SignerPanel: display warning for external transactions (#850) Remove Badge and update occurrences for Tag (#901) SignerPanel: adjust for new styles (#920) Organization Settings: replace old Settings app (#896) Permissions: new style (#899) Sidepanel: redesign feedback indicator (#907) eslint: make sure curly braces are used everywhere (#924) Org switcher: new style + add FavoritesMenu (#925)
Adjusts the signer panel to the new styles:
Feedback statuses are implemented in #907.
Most of the other modes
Direct:
Web3 not installed:
Provider not enabled:
Action impossible:
TODO: