Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppBadges: buggy custom label behaviour #1193

Open
sohkai opened this issue Nov 22, 2019 · 1 comment
Open

AppBadges: buggy custom label behaviour #1193

sohkai opened this issue Nov 22, 2019 · 1 comment
Labels

Comments

@sohkai
Copy link
Contributor

sohkai commented Nov 22, 2019

At least in Permissions, but I suspect elsewhere as well, editing the custom label of an AppBadge does not automatically edit the other badges rendered on the page.

The popover also should not show "custom label" if no custom label has been applied yet.

In general, the AppBadge implementation in the client (from https://github.com/aragon/aragon/pull/983/files) should be re-done completely.

@sohkai
Copy link
Contributor Author

sohkai commented Apr 8, 2020

This may be because App.js's label handlers do not emit events on the identityEvents$ observable used elsewhere (e.g. useIdentitiesActions.js).

Related to #660, we most likely want to redo how these events are wired throughout the client.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant