Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vote, not Voting #53

Closed
luisivan opened this issue Nov 8, 2017 · 7 comments
Closed

Vote, not Voting #53

luisivan opened this issue Nov 8, 2017 · 7 comments
Labels
design: pending enhancement good first issue
Milestone
Alpha 0.5

Comments

@luisivan
Copy link
Contributor

luisivan commented Nov 8, 2017

As suggested by skwp on RocketChat, seems like voting is not even a word, so we should replace it with vote everywhere.
@luisivan luisivan added this to the ÐApp 0.5.0 milestone Nov 8, 2017
@onbjerg
Copy link
Contributor

onbjerg commented Nov 8, 2017 •
edited

Repos affected

  • aragon-apps
  • aragon-wiki

@izqui
Copy link
Contributor

izqui commented Nov 8, 2017 •
edited

All code in the Voting app was modified some time ago to fix this. Some comments and documentation have yet to be modified.

aragon-core is not afected.

@onbjerg
Copy link
Contributor

onbjerg commented Nov 8, 2017

True, that was a brainfart. I meant the wiki.

@MiguelBel
Copy link

Is this a good first issue? should it have the tag "good first issue"?

@izqui
Copy link
Contributor

izqui commented Nov 9, 2017

It is! Help changing this in both the wiki and comments would be greatly appreciated

@onbjerg
Copy link
Contributor

onbjerg commented Nov 10, 2017

Also the contracts should probably be renamed as well.

@MiguelBel I tagged this issue with the "good first issue" label. Let us know if you have any trouble if you end up doing this one 😊

@izqui izqui mentioned this issue Nov 13, 2017
Merged
@izqui
Copy link
Contributor

izqui commented Nov 13, 2017

Updated the wiki aragon/aragon-wiki@b916929

@izqui izqui modified the milestones: Alpha 0.5.0, Alpha 0.5 Nov 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
design: pending enhancement good first issue
Projects
None yet
Milestone
Alpha 0.5
Development

No branches or pull requests
4 participants
@izqui @luisivan @MiguelBel @onbjerg