Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate npm releases #69

Open
bpierre opened this issue Jun 22, 2020 · 0 comments
Open

Automate npm releases #69

bpierre opened this issue Jun 22, 2020 · 0 comments

Comments

@bpierre
Copy link
Contributor

bpierre commented Jun 22, 2020

I think it could be nice to consider the master branch stable, and automate the build + version bump + npm publication using GitHub Actions.

We could:

  • Have a specific line in the PR and merge commit (e.g. change: major|minor|patch) to determinate the new version.
  • Have one of the status checks verifying that the change: information exists (and prevent merging without it).
  • For every merge on master, a workflow would:
    • Build everything.
    • Bump the version.
    • Push the newly created tag.
    • Publish on npm.

The changelog will still be edited manually.

Some things we might want to explore:

Using merge-release

Some potential issues:

  • It only checks at the commit level, so we can’t run a PR status check to verify that the information has been set.
  • It is not as explicit as having a change: major|minor|patch, which might cause issues.
  • I couldn’t make it work with aragonUI and our npm account. For some reason, it never accepts to authenticate, even without OTP.

Using GitHub Packages + npm-package-sync

This would allow to publish on GitHub Packages, and just sync it with npm. It would make things easier if GitHub Packages provide a transparent bridge to npm at some point.

/cc @sohkai @promaty

@bpierre bpierre changed the title Automate releases Automate npm releases Jun 22, 2020
@0xGabi 0xGabi added this to To do in Roadmap to v1.0.0 Aug 18, 2020
@0xGabi 0xGabi removed this from To do in Roadmap to v1.0.0 Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant