Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solrazied color scheme #32

Closed
greduan opened this issue Nov 27, 2012 · 11 comments
Closed

Solrazied color scheme #32

greduan opened this issue Nov 27, 2012 · 11 comments

Comments

@greduan
Copy link
Contributor

greduan commented Nov 27, 2012

Hi, just wanted to say.

Would it be possible to add the Solarized color schemes? Light and dark versions?

I would be interested in doing this myself, if I could just get some documentation on what each thing does and highlights. :)

- Eduan

@aramk
Copy link
Owner

aramk commented Nov 28, 2012

Sure, see the themes section here: http://ak.net84.net/projects/crayon-syntax-highlighter/
Also, take a look at how the classic theme is set up, make a copy of it with a different name and modify the section of the CSS marked "Syntax Highlighting" to change the highlighting colours. I'm working on a theme editor, but it won't be ready for another few weeks I'm guessing.

@greduan
Copy link
Contributor Author

greduan commented Nov 28, 2012

Hmm, thanks! I did all I could, but without some kind of comment telling me what each thing is supposed to highlight, it's going to be really hard to develop a theme. :/

You think in the next release you could comment what each thing represents? Because I was very confused. Thanks!

@aramk
Copy link
Owner

aramk commented Nov 28, 2012

@aramk
Copy link
Owner

aramk commented Nov 28, 2012

Updated the crayon help also to point there

@greduan
Copy link
Contributor Author

greduan commented Nov 28, 2012

That works, thanks! I'll start working on it. :)

@greduan
Copy link
Contributor Author

greduan commented Nov 28, 2012

I'm afraid this is the nearest I could get with my knowledge of your plugin. You think you could finish it? Here's an image of what it should look like, it's the light version, but anything that's different from the dark version is already covered. :) http://content.screencast.com/users/Eduan/folders/Sublime%20Text/media/374eecdb-5015-40fd-8b53-cbcdf8b36f50/Screen%20Shot%202012-11-01%20at%203.31.12%20PM.png

Here's my current version: https://github.com/Greduan/crayon-syntax-highlighter/blob/master/themes/solarized-dark/solarized-dark.css

Also, some things are missing from the documentation, like p for example.

EDIT: Here's the original Solarized repo: https://github.com/altercation/solarized

@aramk
Copy link
Owner

aramk commented Dec 1, 2012

See 22bd3c5

@greduan
Copy link
Contributor Author

greduan commented Dec 1, 2012

That's awesome, thanks!

I think I'll wait for an official update to come out, so that I can test it out on my website. :)

@aramk
Copy link
Owner

aramk commented Dec 2, 2012

Great, I'll release it shortly!

@aramk aramk closed this as completed Dec 2, 2012
@greduan
Copy link
Contributor Author

greduan commented Dec 2, 2012

It looks good, thanks!

I think there's a couple of things to fix in the theme, mostly some things I gotta do a lot of trial and error, but it looks good. If I figure that out I'll also add the light version. :)

@aramk
Copy link
Owner

aramk commented Dec 2, 2012

Good stuff!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants