Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Short-circuit the solution logic if CSRFGuard is disabled #143

Closed
forgedhallpass opened this issue Sep 10, 2020 · 1 comment
Closed

Short-circuit the solution logic if CSRFGuard is disabled #143

forgedhallpass opened this issue Sep 10, 2020 · 1 comment

Comments

@forgedhallpass
Copy link
Collaborator

forgedhallpass commented Sep 10, 2020 •
edited

If CSRFGuard is disabled:

  • The configurations should be lazily initialized: e.g. no validations, no class instances creation with reflection etc.
  • No tokens should be (pre)created by the onSessionCreate
  • The JavaScriptServlet should not serve the regular JS file that makes an additional request, tries to inject tokens to DOM elements and so on.
@forgedhallpass forgedhallpass changed the title The javascript logic should not be applied if CSRFGuard is disabled Short-circuit the solution logic is CSRFGuard is disabled Sep 22, 2020
@forgedhallpass forgedhallpass changed the title Short-circuit the solution logic is CSRFGuard is disabled Short-circuit the solution logic if CSRFGuard is disabled Feb 19, 2021
@forgedhallpass
Copy link
Collaborator Author

Fixed by:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@forgedhallpass