read username/password from server_url #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
given that the URL is structured like: http://username:password@hostname.example.com use that username/password combination rather than requiring explicit :username and :password options in the JenkinsApi::Client initializer.
|
Cool, thanks @spikegrobstein! |
arangamani
added a commit
that referenced
this pull request
Jan 15, 2014
…from-url read username/password from server_url
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
given that the URL is structured like:
http://username:password@hostname.example.com
use that username/password combination rather than requiring explicit
:username and :password options in the JenkinsApi::Client initializer.
If the :username/:password options are included, then use those.