Support SSL on Ruby 1.8.7 / JRuby 1.6 #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Under older versions of Ruby, SSL needed to be turned on after creating the HTTP object, but before making a request, as a separate method call; and you must require 'net/https'. In addition to the above, this brings more consistency under which circumstances the SSL and proxy configuration variables are applied when using server_ip instead of server_url to configure the location of the Jenkins server.
|
Looks good. When do you expect a new gem by? |
|
Thanks for the quick response! It would be helpful to us to ship with a proper release by the end of the week, but we're equipped to package our own one if needed. |
|
I'm making some major changes for the next release and need to do more testing. If I can't get that done soon, I might cherry-pick this commit to |
arangamani
added a commit
that referenced
this pull request
Jun 25, 2013
Support SSL on Ruby 1.8.7 / JRuby 1.6
Closed
|
Version |
|
Thanks again :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under older versions of Ruby, SSL needed to be turned on after creating the
HTTP object, but before making a request, as a separate method call; and you
must require 'net/https'.
In addition to the above, this brings more consistency under which
circumstances the SSL and proxy configuration variables are applied when
using server_ip instead of server_url to configure the location of the
Jenkins server.