Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use asynchronous test fixtures #16

Closed
DiscoPYF opened this issue Nov 7, 2019 · 0 comments
Closed

Use asynchronous test fixtures #16

DiscoPYF opened this issue Nov 7, 2019 · 0 comments

Comments

@DiscoPYF
Copy link
Collaborator

DiscoPYF commented Nov 7, 2019

Currently, we wait for tasks in the constructor and Dispose method of our test fixtures, e.g. CollectionApiClientTestFixture. This causes deadlocks when running tests in parallels with a fixed limited number of threads.

XUnit provides IAsyncLifetime to support for asynchronous initialization and cleanup operations. We should use that and support async all the way.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rossmills99 @DiscoPYF