Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The order of allowlist entries and comments in allowlist file is lost when updating the allowlist #147

Open
rossmills99 opened this issue Jun 2, 2023 · 0 comments

Comments

@rossmills99
Copy link

I've used comments in the allowlist file to help identify the purpose for different IP ranges in there.

Unfortunately when we use oasisctl to update the allowlist using add-cidr-range-strings argument, the CIDR ranges are sorted which means I lose the ordering I have specified for IP ranges, as well as losing the context for comments that were added.

I've identified the following line which appears to apply a sort on the CIDR ranges when they are updated. I'm proposing here that should not be done - as a user, I expect any CIDR ranges to be added at the end of my list and I do care about the order of the ranges and the associated comments.

https://github.com/arangodb-managed/oasisctl/blob/7d02214cd338cbfc2e2780c5bb724a8e3fe31b64/cmd/security/update_ipallowlist.go#LL122C9-L122C35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant