You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've used comments in the allowlist file to help identify the purpose for different IP ranges in there.
Unfortunately when we use oasisctl to update the allowlist using add-cidr-range-strings argument, the CIDR ranges are sorted which means I lose the ordering I have specified for IP ranges, as well as losing the context for comments that were added.
I've identified the following line which appears to apply a sort on the CIDR ranges when they are updated. I'm proposing here that should not be done - as a user, I expect any CIDR ranges to be added at the end of my list and I do care about the order of the ranges and the associated comments.
I've used comments in the allowlist file to help identify the purpose for different IP ranges in there.
Unfortunately when we use oasisctl to update the allowlist using
add-cidr-range-strings
argument, the CIDR ranges are sorted which means I lose the ordering I have specified for IP ranges, as well as losing the context for comments that were added.I've identified the following line which appears to apply a sort on the CIDR ranges when they are updated. I'm proposing here that should not be done - as a user, I expect any CIDR ranges to be added at the end of my list and I do care about the order of the ranges and the associated comments.
https://github.com/arangodb-managed/oasisctl/blob/7d02214cd338cbfc2e2780c5bb724a8e3fe31b64/cmd/security/update_ipallowlist.go#LL122C9-L122C35
The text was updated successfully, but these errors were encountered: