Skip to content
This repository has been archived by the owner on Dec 13, 2023. It is now read-only.

Update Swagger file in main repo (automatically?) #124

Closed
Simran-B opened this issue Jul 29, 2019 · 3 comments
Closed

Update Swagger file in main repo (automatically?) #124

Simran-B opened this issue Jul 29, 2019 · 3 comments

Comments

@Simran-B
Copy link
Collaborator

Backport to 3.5 / 3.4?
arangodb/arangodb#9045

Does the Swagger file get re-generated and committed in the main repo on every release?
https://github.com/arangodb/arangodb/commits/3.5/js/apps/system/_admin/aardvark/APP/api-docs.json

Do we need to manually update it / can we automate this?

@Simran-B Simran-B self-assigned this Jul 29, 2019
@dothebart
Copy link
Contributor

#9045 should be backported.

@Simran-B
Copy link
Collaborator Author

arangodb/arangodb#9602
arangodb/arangodb#9603

The Swagger file was definitely missing the minReplicationFactor changes, which was added in v3.5.0-rc.5 (2019-07-22):

@@ -726,6 +751,11 @@
                 "keyOptions": {
                     "$ref": "#/definitions/key_generator_type"
                 },
+                "minReplicationFactor": {
+                    "description": "contains how many minimal copies of each shard need to be in sync on different DBServers.\nThe shards will refuse to write, if we have less then these many copies in sync. *Cluster specific attribute.*\n\n",
+                    "format": "",
+                    "type": "integer"
+                },
                 "name": {
                     "description": "literal name of this collection\n\n",
                     "type": "string"

So I guess sometimes it was updated manually but this time it was not and there is no automatic process to do it.

@Simran-B
Copy link
Collaborator Author

Jenkins job arangodb-ANY-examples can be used to re-generate examples + Swagger in the docs repo, then the Swagger JSON file can be picked and copied over to the main repo where it is used by the Web UI (for Swagger UI).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants