Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to disable request timeout #261

Closed
153957 opened this issue Jul 17, 2023 · 2 comments
Closed

Unable to disable request timeout #261

153957 opened this issue Jul 17, 2023 · 2 comments

Comments

@153957
Copy link
Contributor

153957 commented Jul 17, 2023

Previously it was possible to disable the timeout for the HTTP client by setting request_timeout to None, but after: #257 it 'has' to be an int of float.
So the timeout can no longer be easily disabled (can of course be set super high, but that means having to set it to something instead of clearly nothing/unlimited).

Please allow None as a value for the request_timeout.
@aMahanna aMahanna mentioned this issue Aug 1, 2023
Merged
@aMahanna
Copy link
Member

aMahanna commented Aug 1, 2023

Hey @153957, #265 should fix the mypy issue you are seeing

@153957
Copy link
Contributor Author

153957 commented Aug 1, 2023

Thank you!

@153957 153957 closed this as completed Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@153957 @aMahanna