Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bind_vars type hints are incomplete #288

Closed
valentingregoire opened this issue Sep 20, 2023 · 4 comments · Fixed by #289
Closed

bind_vars type hints are incomplete #288

valentingregoire opened this issue Sep 20, 2023 · 4 comments · Fixed by #289

Comments

@valentingregoire
Copy link
Contributor

According to this and this piece of code, the bind vars values should be strings. That seems to be incorrect, since values in ArangoDB are not always strings.

Docs: https://docs.arangodb.com/3.11/aql/fundamentals/data-types/

@apetenchea
Copy link
Member

Hi @valentingregoire,

You're right, thanks for pointing out this discrepancy in the type hinting.

Given your understanding of the issue, we always encourage contributions and would be happy to offer you the opportunity to address this if you're interested. For smaller pull requests, we aim to make this experience collaborative. However, if you'd prefer not to or if you're pressed for time, I'm happy to take a look and address it when I get a chance.

Please let me know how you'd like to proceed!

@valentingregoire
Copy link
Contributor Author

I will take care of it, no worries.

@valentingregoire
Copy link
Contributor Author

@apetenchea, PR is submitted: #289

Feel free to change stuff, provide feedback, ...

@apetenchea
Copy link
Member

@apetenchea, PR is submitted: #289

Feel free to change stuff, provide feedback, ...

Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants