Preparation to accommodate more languages #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eirikurn
requested changes
Apr 17, 2020
|
Also. We should consider the ordering and presentation of the languages. UX wise I'd like Icelandic to be pre-selected at the top. But the other languages should probably be ordered alphabetically. Looking at covid.is, they order the languages alphabetically. They also prefix the non-Latin languages (like Thai) with the language name in Icelandic ... which is a bit weird to me, but at least it simplifies the alphabetic ordering. P.s. awesome job with this PR! |
|
Merged master into this branch, added the missing keys to FR and TH, and changed the order of the languages. This is how it looks: |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed styles after the feedback from #58 to accommodate the new translations that are going to come in the upcoming days.
Also removed an old script after feedback from #62.
This is an example with fake languages:
