Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation fails on Cygwin because of cygwin_conv_to_full_path_path() #111

Open
vinriviere opened this issue Feb 15, 2024 · 2 comments
Open

Comments

@vinriviere
Copy link
Contributor

I've just tried to compile ARAnyM on Cygwin64 from Git sources.
It fails with:

../../aranym-GIT-20240215/src/Unix/cygwin/tools_cygwin.cpp: In function ‘char* cygwin_path_to_win32(char*, size_t)’:
../../aranym-GIT-20240215/src/Unix/cygwin/tools_cygwin.cpp:16:9: error: ‘cygwin_conv_to_full_win32_path’ was not declared in this scope
   16 |         cygwin_conv_to_full_win32_path(path, winpath);
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

(same at line 28)

Source:

#if defined(CYGWIN_VERSION_CYGWIN_CONV) && CYGWIN_VERSION_DLL_COMBINED >= CYGWIN_VERSION_CYGWIN_CONV
cygwin_conv_path(CCP_POSIX_TO_WIN_A | CCP_ABSOLUTE, path, winpath, sizeof(winpath));
#else
cygwin_conv_to_full_win32_path(path, winpath);
#endif

I have no idea where that cygwin_conv_to_full_win32_path() comes from.
I replaced the complex #if ... with #if 1. This fixes the compilation, and works well (#22 is indeed fixed).

@th-otto
Copy link
Member

th-otto commented Feb 16, 2024

It's supposed to be declared in <sys/cygwin.h>, but maybe that is no longer the case with newer cygwin versions. Did you only change the first #if? There is another one a few lines later.

@vinriviere
Copy link
Contributor Author

There is no cygwin_conv_to_full_path_path() in current Cygwin's /usr/include/sys/cygwin.h.

And yes, I needed to change the 2 #if.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants