Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Under is not the opposite of Above #43

Closed
tbasse opened this issue Feb 6, 2015 · 2 comments
Closed

Under is not the opposite of Above #43

tbasse opened this issue Feb 6, 2015 · 2 comments

Comments

@tbasse
Copy link

tbasse commented Feb 6, 2015

First of all, excuse me in advance if I'm very picky here but the naming of the is.above() and is.under() methods are really bothering me. It really should be above/below or over/under but definitely not abover/under :)

Maybe just rename is.under() to is.below() and alias those methods to is.over() and is.under().

Again, I might be very picky here but the current naming just looks very odd.

@arasatasaygin
Copy link
Owner

Nope, you are not picky @tbasse
My English just sucks. Thanks for the suggestion.

@arasatasaygin
Copy link
Owner

Listed this suggestion here > #44
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants